ci: Improve performance of go lint and formatting

- Add additional filters for `find` so it does not need to traverse
  irrelevant dirs
- Allow parallel golangci-lint runs so node/ and sdk/ run at the same
  time

Author: johnsaigle

node/Makefile

@@ -1,6 +1,6 @@
 .PHONY: lint
 lint: 
-	golangci-lint run -c ../.golangci.yml ./...
+	golangci-lint run -c ../.golangci.yml --allow-parallel-runners ./...
 
 .PHONY: test
 test: 

scripts/lint.sh

@@ -42,8 +42,11 @@ format(){
         exit 1
     fi
 
-    # Use -exec because of pitfall #1 in http://mywiki.wooledge.org/BashPitfalls
-    GOFMT_OUTPUT="$(find "./sdk" "./node" "./wormchain" -type f -name '*.go' -not -path '*.pb.go' -print0 | xargs -r -0 goimports $GOIMPORTS_ARGS 2>&1)"
+    GOFMT_OUTPUT="$(find "./sdk" "./node" "./wormchain" \
+        \( -name node_modules -prune \) -o \
+        \( -name .gocache -prune \) -o \
+        \( -name target -prune \) -o \
+        -type f -name '*.go' -not -path '*.pb.go' -print0 | xargs -r -0 goimports $GOIMPORTS_ARGS 2>&1)"
 
     if [ -n "$GOFMT_OUTPUT" ]; then
         if [ "$GITHUB_ACTION" == "true" ]; then
@@ -55,25 +58,45 @@ format(){
 }
 
 lint(){
+    LINT_EXIT=0
+
     # === Spell check
     if ! command -v cspell >/dev/null 2>&1; then
         printf "%s\n" "cspell is not installed. Skipping spellcheck"
     else
-        cspell "*/**.*md"
+        cspell "*/**.*md" &
+        CSPELL_PID=$!
     fi
-    
+
     # === Go linting
     # Check for dependencies
     if ! command -v golangci-lint >/dev/null 2>&1; then
         printf "%s\n" "Require golangci-lint. You can run this command in a docker container instead with '-c' and not worry about it or install it: https://golangci-lint.run/usage/install/"
     fi
 
     # Do the actual linting!
-    cd "$ROOT"/node
-    golangci-lint run --timeout=10m $GOLANGCI_LINT_ARGS ./...
+    (
+        cd "$ROOT"/node
+        golangci-lint run --timeout=10m --allow-parallel-runners $GOLANGCI_LINT_ARGS ./...
+    ) &
+    NODE_PID=$!
+
+    (
+        cd "${ROOT}/sdk"
+        golangci-lint run --timeout=10m --allow-parallel-runners $GOLANGCI_LINT_ARGS ./...
+    ) &
+    SDK_PID=$!
+
+    wait $NODE_PID || LINT_EXIT=1
+    wait $SDK_PID || LINT_EXIT=1
+
+    if [ -n "${CSPELL_PID:-}" ]; then
+        wait $CSPELL_PID || LINT_EXIT=1
+    fi
 
-    cd "${ROOT}/sdk"
-    golangci-lint run --timeout=10m $GOLANGCI_LINT_ARGS ./...
+    if [ $LINT_EXIT -ne 0 ]; then
+        exit 1
+    fi
 }
 
 DOCKER="false"