node: Remove minimum TxID length

Author: johnsaigle

node/pkg/common/chainlock.go

@@ -17,8 +17,6 @@ import (
 )
 
 const (
-	// TxIDLenMin is the minimum length of a txID.
-	TxIDLenMin = 32
 	// AddressLength is the length of a normalized Wormhole address in bytes.
 	AddressLength = 32
 
@@ -37,7 +35,6 @@ const (
 	// The minimum size of a marshaled message publication. It is the sum of the sizes of each of
 	// the fields plus length information for fields with variable lengths (TxID and Payload).
 	marshaledMsgLenMin = 1 + // TxID length (uint8)
-		TxIDLenMin + // TxID ([]byte), minimum length of 32 bytes (but may be longer)
 		8 + // Timestamp (int64)
 		4 + // Nonce (uint32)
 		8 + // Sequence (uint64)
@@ -103,7 +100,6 @@ var ErrInputTooLarge = errors.New("input data exceeds maximum allowed size")
 var (
 	ErrBinaryWrite         = errors.New("failed to write binary data")
 	ErrTxIDTooLong         = errors.New("field TxID too long")
-	ErrTxIDTooShort        = errors.New("field TxID too short")
 	ErrInvalidPayload      = errors.New("field payload too long")
 	ErrDataTooShort        = errors.New("data too short")
 	ErrTimestampTooShort   = errors.New("data too short for timestamp")
@@ -191,6 +187,8 @@ type MessagePublication struct {
 	// whose buckets reach quorum at different observation subsets can still
 	// pick different majorities; recovery for that case is the audit /
 	// missing_observations reobs flow rather than the delegate-quorum path.
+	//
+	// TxID identifies the transaction that emitted this message. There is no minimum length.
 	TxID      []byte
 	Timestamp time.Time
 
@@ -357,17 +355,12 @@ func (msg *MessagePublication) MarshalBinary() ([]byte, error) {
 		return nil, ErrInputSize{Msg: "TxID too long", Want: TxIDSizeMax, Got: txIDLen}
 	}
 
-	if txIDLen < TxIDLenMin {
-		return nil, ErrInputSize{Msg: "TxID too short", Want: TxIDLenMin, Got: txIDLen}
-	}
-
 	payloadLen := len(msg.Payload)
 	// Set up for serialization
 	var (
 		be = binary.BigEndian
 		// Size of the buffer needed to hold the serialized message.
-		// TxIDLenMin is already accounted for in the marshaledMsgLenMin calculation.
-		bufSize = (marshaledMsgLenMin - TxIDLenMin) + txIDLen + payloadLen
+		bufSize = marshaledMsgLenMin + txIDLen + payloadLen
 		buf     = make([]byte, 0, bufSize)
 	)
 
@@ -528,12 +521,8 @@ func (m *MessagePublication) UnmarshalBinary(data []byte) error {
 	txIDLen := uint8(data[pos])
 	pos++
 
-	// Bounds checks. TxID length should be at least TxIDLenMin, but not larger than the length of the data.
-	// The second check is to avoid panics.
-	if int(txIDLen) < TxIDLenMin {
-		return ErrInputSize{Msg: "TxID length is too short", Got: int(txIDLen), Want: TxIDLenMin}
-	}
-
+	// Bounds check. TxID length should not be larger than the length of the data.
+	// This check avoids panics.
 	if int(txIDLen) > len(data) {
 		return ErrInputSize{Msg: "TxID length is longer than bytes", Got: int(txIDLen)}
 	}

node/pkg/common/chainlock_test.go

@@ -299,7 +299,7 @@ func TestMessagePublicationUnmarshalBinaryErrors(t *testing.T) {
 func FuzzMessagePublicationUnmarshalBinary(f *testing.F) {
 	// Create a valid message publication for seeding
 	orig := &MessagePublication{
-		TxID:              make([]byte, TxIDLenMin), // Use minimum valid TxID length
+		TxID:              make([]byte, 32), // 32-byte tx hash (typical Ethereum hash)
 		Timestamp:         time.Unix(int64(1654516425), 0),
 		Nonce:             123456,
 		Sequence:          789101112131415,
@@ -349,9 +349,6 @@ func FuzzMessagePublicationUnmarshalBinary(f *testing.F) {
 			if len(mp.TxID) > 255 {
 				t.Errorf("TxID length %d exceeds maximum of 255", len(mp.TxID))
 			}
-			if len(mp.TxID) < TxIDLenMin && len(mp.TxID) > 0 {
-				t.Errorf("TxID length %d is less than minimum of %d (unless empty)", len(mp.TxID), TxIDLenMin)
-			}
 
 			// Verify that a successful unmarshal can be marshaled back
 			_, marshalErr := mp.MarshalBinary()

node/pkg/common/pendingmessage_test.go

@@ -69,10 +69,6 @@ func TestPendingMessage_MarshalError(t *testing.T) {
 	var (
 		longTxID = bytes.NewBuffer(make([]byte, math.MaxUint8+1))
 	)
-	emitter, err := vaa.StringToAddress("0x707f9118e33a9b8998bea41dd0d46f38bb963fc8")
-	require.NoError(t, err)
-
-	require.NoError(t, err)
 
 	tests := []test{
 		{
@@ -82,22 +78,6 @@ func TestPendingMessage_MarshalError(t *testing.T) {
 			},
 			errMsg: "wrong size: TxID too long",
 		},
-		{
-			label: "txID too short",
-			input: common.MessagePublication{
-				TxID:             []byte{},
-				Timestamp:        time.Unix(int64(1654516425), 0),
-				Nonce:            123456,
-				Sequence:         789101112131415,
-				EmitterChain:     vaa.ChainIDEthereum,
-				EmitterAddress:   emitter,
-				Payload:          []byte{},
-				ConsistencyLevel: 32,
-				Unreliable:       true,
-				IsReobservation:  true,
-			},
-			errMsg: "wrong size: TxID too short",
-		},
 	}
 
 	for _, tc := range tests {

node/pkg/processor/delegate_obs.go

@@ -59,9 +59,6 @@ func delegateObservationToMessagePublication(d *gossipv1.DelegateObservation) (*
 	if txIDLen > TxIDSizeMax {
 		return nil, fmt.Errorf("delegate observation tx_hash too long: got %d; want at most %d", txIDLen, TxIDSizeMax)
 	}
-	if txIDLen < node_common.TxIDLenMin {
-		return nil, fmt.Errorf("delegate observation tx_hash too short: got %d; want at least %d", txIDLen, node_common.TxIDLenMin)
-	}
 
 	if d.ConsistencyLevel > math.MaxUint8 {
 		return nil, fmt.Errorf("invalid delegate observation consistency : %d", d.ConsistencyLevel)
@@ -117,9 +114,6 @@ func messagePublicationToDelegateObservation(m *node_common.MessagePublication)
 	if txIDLen > TxIDSizeMax {
 		return nil, fmt.Errorf("message publication tx_hash too long: got %d; want at most %d", txIDLen, TxIDSizeMax)
 	}
-	if txIDLen < node_common.TxIDLenMin {
-		return nil, fmt.Errorf("message publication tx_hash too short: got %d; want at least %d", txIDLen, node_common.TxIDLenMin)
-	}
 
 	// Check if payload length is within max message size for p2p
 	if len(m.Payload) > node_common.DelegatedPayloadLenMax {