Minor results optimisation

Author: 1337LutZ

sim/mage/flamestrike.go

@@ -17,7 +17,7 @@ func (mage *Mage) GetFlameStrikeConfig(spellId int32, isProc bool) core.SpellCon
 		ActionID:       core.ActionID{SpellID: spellId},
 		SpellSchool:    core.SpellSchoolFire,
 		ProcMask:       core.ProcMaskSpellDamage,
-		Flags:          core.SpellFlagAoE | core.SpellFlag(core.TernaryInt32(isProc, 0, int32(core.SpellFlagAPL))),
+		Flags:          core.SpellFlagAoE | core.Ternary(isProc, core.SpellFlagNone, core.SpellFlagAPL),
 		ClassSpellMask: MageSpellFlamestrike,
 		Cast: core.CastConfig{
 			DefaultCast: core.Cast{

sim/shaman/_fire_totems.go

@@ -12,6 +12,8 @@ func searingTickCount(shaman *Shaman, offset float64) int32 {
 }
 
 func (shaman *Shaman) registerSearingTotemSpell() {
+	results := make([]*core.SpellResult, shaman.Env.GetNumTargets())
+
 	shaman.SearingTotem = shaman.RegisterSpell(core.SpellConfig{
 		ActionID:       core.ActionID{SpellID: 3599},
 		SpellSchool:    core.SpellSchoolFire,
@@ -101,7 +103,6 @@ func (shaman *Shaman) registerMagmaTotemSpell() {
 			BonusCoefficient: 0.06700000167,
 
 			OnTick: func(sim *core.Simulation, target *core.Unit, dot *core.Dot) {
-				results := make([]*core.SpellResult, shaman.Env.GetNumTargets())
 				baseDamage := shaman.CalcScalingSpellDmg(0.26699998975)
 				for i, aoeTarget := range sim.Encounter.TargetUnits {
 					results[i] = dot.Spell.CalcPeriodicDamage(sim, aoeTarget, baseDamage, dot.Spell.OutcomeMagicHitAndCrit)

sim/shaman/elemental/thunderstorm.go

@@ -17,6 +17,8 @@ func (elemental *ElementalShaman) registerThunderstormSpell() {
 		manaRestore = 0.02
 	}
 
+	results := make([]*core.SpellResult, elemental.Env.GetNumTargets())
+
 	elemental.Thunderstorm = elemental.RegisterSpell(core.SpellConfig{
 		ActionID:       actionID,
 		Flags:          core.SpellFlagAoE | core.SpellFlagAPL | shaman.SpellFlagFocusable,
@@ -44,7 +46,6 @@ func (elemental *ElementalShaman) registerThunderstormSpell() {
 			elemental.AddMana(sim, elemental.MaxMana()*manaRestore, manaMetrics)
 
 			if elemental.Shaman.ThunderstormInRange {
-				results := make([]*core.SpellResult, elemental.Env.GetNumTargets())
 				for i, aoeTarget := range sim.Encounter.TargetUnits {
 					baseDamage := elemental.GetShaman().CalcAndRollDamageRange(sim, 1.62999999523, 0.13300000131)
 					results[i] = spell.CalcDamage(sim, aoeTarget, baseDamage, spell.OutcomeMagicHitAndCrit)