Skip to content

Commit e9b2978

Browse files
committed
cone of cold correctly should be AOE, T14 spell mod chaining
1 parent 7af986e commit e9b2978

2 files changed

Lines changed: 6 additions & 11 deletions

File tree

sim/mage/cone_of_cold.go

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,6 @@ var coneOfColdVariance = 0.0 // Per https://wago.tools/db2/SpellEffect?build
1212

1313
func (mage *Mage) registerConeOfColdSpell() {
1414

15-
//hasGlyph := mage.HasMajorGlyph(proto.MageMajorGlyph_GlyphOfFrostfireBolt)
16-
//TODO: post glyph implementation updates
17-
1815
mage.RegisterSpell(core.SpellConfig{
1916
ActionID: core.ActionID{SpellID: 120},
2017
SpellSchool: core.SpellSchoolFrost,
@@ -43,7 +40,9 @@ func (mage *Mage) registerConeOfColdSpell() {
4340

4441
ApplyEffects: func(sim *core.Simulation, target *core.Unit, spell *core.Spell) {
4542
baseDamage := mage.CalcAndRollDamageRange(sim, coneOfColdScaling, coneOfColdVariance)
46-
spell.CalcAndDealDamage(sim, target, baseDamage, spell.OutcomeMagicHitAndCrit)
43+
for _, aoeTarget := range sim.Encounter.TargetUnits {
44+
spell.CalcAndDealDamage(sim, aoeTarget, baseDamage, spell.OutcomeMagicHitAndCrit)
45+
}
4746
},
4847
})
4948
}

sim/mage/items.go

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -140,13 +140,11 @@ var ItemSetRegaliaOfTheBurningScroll = core.NewItemSet(core.ItemSet{
140140
Kind: core.SpellMod_DamageDone_Pct,
141141
ClassMask: MageSpellIceLance,
142142
FloatValue: 0.12,
143-
})
144-
setBonusAura.AttachSpellMod(core.SpellModConfig{
143+
}).AttachSpellMod(core.SpellModConfig{
145144
Kind: core.SpellMod_DamageDone_Pct,
146145
ClassMask: MageSpellArcaneMissilesTick,
147146
FloatValue: 0.07,
148-
})
149-
setBonusAura.AttachSpellMod(core.SpellModConfig{
147+
}).AttachSpellMod(core.SpellModConfig{
150148
Kind: core.SpellMod_DamageDone_Pct,
151149
ClassMask: MageSpellPyroblast | MageSpellPyroblastDot,
152150
FloatValue: 0.08,
@@ -161,9 +159,7 @@ var ItemSetRegaliaOfTheBurningScroll = core.NewItemSet(core.ItemSet{
161159
FloatValue: -0.5,
162160
Kind: core.SpellMod_Cooldown_Multiplier,
163161
ClassMask: MageSpellIcyVeins,
164-
})
165-
166-
setBonusAura.AttachSpellMod(core.SpellModConfig{
162+
}).AttachSpellMod(core.SpellModConfig{
167163
FloatValue: -0.2,
168164
Kind: core.SpellMod_Cooldown_Multiplier,
169165
ClassMask: MageSpellCombustion,

0 commit comments

Comments
 (0)