Support type conversion crossing integer with duration

[malvanis]

Link:
http://localhost:3333/mop/warlock/destruction/#eJztVmtoHFUU3nPnsbMnrZ1ck3Ry2trNNAlhNOnuhjyrZlsoVvFRpIh/RAKtogjWRBCrQitCMBYbE22Tpa9UpU1ADauCjVhC4qM+CjW0pqlFJPRHkP7w9adS0HvvzGw2aWOiPxTBG0LunPm+8z5ngk4V3A/boQtgBGAaYCeDLqb3MrbBtMGBNPAIDRVnNHPzY61Pb2uzYnaMJgGX2K8OGK559pzeOaFj1P71qFG1W4r3DRjOpxWuJsVod40Zzv7Kqn2A3N4l3oy5rrl3Qt85oVe9CLjUfuOo4ZxwXYhIiG33CMjX6jEDm45UCtInRw03JuBCneAJMS6zXxOoSWFCCnql4LjQ8qXraoHaqP2m8KYH0LT3jBlVT6FudwwYQtx3zPA1vCLcOu8qJ6u6QPg5JDSMu4Lj2tZH47otfp33x/VE5jPd+4A5gEMQ+Y8dvvNfd7n5W4aRP//h/2f3754NkQwzUUdmwTAzU6lkqjY5yiInmX6aFZxnkSl2camjYRGaJEBOoYtooVmdrGmoa8cStEiQrcw05Mu5Tqw5wlcSoe1dZ+mc3REhZaQ+qfCXuoD3Ax0E7AESo/Ms34HGF0z4gE/Q41jiFVkGjw2DxI5eNslADaEOV/ysO5Zm/x4ecGauuJqvUta0GWt1dRjr1qSSny5EcblXPKNVCHxMsnEuK5WSf+Xw8sNABwC7gfYAFnrLgkiiKPxJpdqVRuCxTjP0U/ET7Xgb36iCMHnseXNWEEl0vBKhJ4+k1NU1tM+10CBEEmwGPkuPAtuJdgrYfC1V4xoqw1g2zFZ4lTH7V8WUov4OxsvJRYdKribkUMdPAW+mRqyhm1RujLz61S/Affm7KEfyu6LvB5PfQuswydfiEtkfKSk99raJq2kVxjK5yvhGtCmIBEmiAMjjdAMWEZ9bono//rMvAW+iBqzmN6rkCR3n9QBSW68qoPHYqPL1496or7xWUX/rinKX4goDYZUGd4OPUR0gH3kllW9wUbMuMFuj0iwrEWgroxtKRFaG+TfeSg/ifbRFtYTOo4/mAAEUm3gDrqIVWOotF07liDTT5YG/Oa7fBDV1FJjo1KlDxysav6yJnXdBo0kNn6NnkDxHhqnGWMZFM+2CFd6a2e+KhqEQl1kHr5jxvNmZR4Ws5rzvpMcTjJ9huNKj2YiCYRC7wOp/z4wDvstoiGGtlxTlqcgyVyRQVUklU9CGWTiPKuBETWNQwMSCpHfOXIN0q3ezICWyrDoklWdZmSAVDarQD80K/a8YHQxzcjXpHn7XvAM/v8I5OyBf4UK9e7sFtBHX8aZwbyaoJlx2aizVVfVAIJW1LOjWcoXJTdAJoA/lx5O/BaGy14EOA1Z65XJTzazh4izjwisVQ1BuoWAWTi2CReBUwReDkzW+Ni4XQDFdj7EpPcxUOLpKnIV8sfhO5baThIR3IZ9mW39ke2GX5n8Wm9KdWsQ9xDZBTD2PtKUL/Td3p0szffJ83tLkS063lD2kzjct6099Jc+lltRF2D74C+wouLf1ka3xLa1tD297Mv6AE/X+oX9SNr+QXgxsJH0uH3dn44H96+diVJTfn4yv7wM/8MmWEJP+AyIRxWY=

RNG Seed: 2203906669

Unimplemented GetInt
Stack Trace:
goroutine 1142 [running]:
runtime/debug.Stack()
/usr/local/go/src/runtime/debug/stack.go:26 +0x5e
github.com/wowsims/mop/sim/core.runSim.func1()
/home/marcel/wowsims-mop/sim/core/sim.go:125 +0x9a
panic({0xd07e40?, 0x32f87a0?})
/usr/local/go/src...

Tried using cast time of shadowburn or immolate in math operation.

[InDebt]

Yeah we don't support many type conversions right now. Burning embers is tracked as an integer 1-40 and the cast time a Duration internally.

Is this something we should support? Integer * Time multiplications? :)

[malvanis]

Probably a good idea. I was trying to do things that you would normally guesstimate while playing destro such as casting chaos bolts if theres enough time to fit into procs or if there's enough time to spend before your big cds are up again. Can probably do this without cast times by using a constant but that wouldn't scale with haste. I guess if you're estimating it in your head you don't think much about your haste and its more a feel.

…

On Wed, Jun 25, 2025 at 11:15 AM InDebt ***@***.***> wrote: *InDebt* left a comment (wowsims/mop#256) <#256 (comment)> Yeah we don't support many type conversions right now. Burning embers is tracked as an integer 1-40 and the cast time a Duration internally. Is this something we should support? Integer * Time multiplications? :) — Reply to this email directly, view it on GitHub <#256 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/APKFHWVANLKUOJN6EML4ZM33FJSDTAVCNFSM6AAAAAB72CNEF6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTAMBUGAZTENJSGY> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[malvanis]

Seems weird that you wouldnt be able to multiply these together though? I guess the units are tied to the value or something rather than being separate and all things considered "time" values being interpreted in second or something?

…

On Fri, Jun 27, 2025 at 11:07 AM Malvanis ***@***.***> wrote: Probably a good idea. I was trying to do things that you would normally guesstimate while playing destro such as casting chaos bolts if theres enough time to fit into procs or if there's enough time to spend before your big cds are up again. Can probably do this without cast times by using a constant but that wouldn't scale with haste. I guess if you're estimating it in your head you don't think much about your haste and its more a feel. On Wed, Jun 25, 2025 at 11:15 AM InDebt ***@***.***> wrote: > *InDebt* left a comment (wowsims/mop#256) > <#256 (comment)> > > Yeah we don't support many type conversions right now. Burning embers is > tracked as an integer 1-40 and the cast time a Duration internally. > > Is this something we should support? Integer * Time multiplications? :) > > — > Reply to this email directly, view it on GitHub > <#256 (comment)>, or > unsubscribe > <https://github.com/notifications/unsubscribe-auth/APKFHWVANLKUOJN6EML4ZM33FJSDTAVCNFSM6AAAAAB72CNEF6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTAMBUGAZTENJSGY> > . > You are receiving this because you authored the thread.Message ID: > ***@***.***> >

[kayla-glick]

@InDebt I think that's a valid use case that we should support if possible, yeah

[vvolodin]

I was looking into this last week. The problem is math value reporting its type as the left operand's type which is not ideal when implementing commutative operations. I can come up with a fix over the next couple of days unless anyone else is already looking into this.