Fix 1% Melee Hit Suppression and Truncate Expertise

TheBackstabi · TheBackstabi · commit 5b9443286742 · 2026-01-31T02:18:19.000-05:00
diff --git a/sim/core/spell_result.go b/sim/core/spell_result.go
@@ -157,14 +157,13 @@ func (spell *Spell) RangedAttackPower() float64 {
 }
 
 func (spell *Spell) DodgeParrySuppression() float64 {
-	// TBC ANNI: Verify if Expertise truncates
 	expertiseRating := spell.Unit.stats[stats.ExpertiseRating] + spell.BonusExpertiseRating
-	return expertiseRating / ExpertisePerQuarterPercentReduction / 400
+	return math.Floor(expertiseRating/ExpertisePerQuarterPercentReduction) / 400
 }
 
 func (spell *Spell) PhysicalHitChance(attackTable *AttackTable) float64 {
 	hitPercent := spell.Unit.stats[stats.PhysicalHitPercent] + spell.BonusHitPercent - attackTable.Defender.PseudoStats.ReducedPhysicalHitTakenChance
-	return hitPercent / 100
+	return max(hitPercent/100-attackTable.HitSuppression, 0)
 }
 func (spell *Spell) PhysicalHitCheck(sim *Simulation, attackTable *AttackTable) bool {
 	return sim.Proc(1.0-spell.GetPhysicalMissChance(attackTable), "Physical Hit Roll")

Original file line number	Diff line number	Diff line change
`@@ -157,14 +157,13 @@ func (spell *Spell) RangedAttackPower() float64 {`
`157`	`157`	`}`
`158`	`158`
`159`	`159`	`func (spell *Spell) DodgeParrySuppression() float64 {`
`160`		`- // TBC ANNI: Verify if Expertise truncates`
`161`	`160`	`expertiseRating := spell.Unit.stats[stats.ExpertiseRating] + spell.BonusExpertiseRating`
`162`		`- return expertiseRating / ExpertisePerQuarterPercentReduction / 400`
	`161`	`+ return math.Floor(expertiseRating/ExpertisePerQuarterPercentReduction) / 400`
`163`	`162`	`}`
`164`	`163`
`165`	`164`	`func (spell Spell) PhysicalHitChance(attackTable AttackTable) float64 {`
`166`	`165`	`hitPercent := spell.Unit.stats[stats.PhysicalHitPercent] + spell.BonusHitPercent - attackTable.Defender.PseudoStats.ReducedPhysicalHitTakenChance`
`167`		`- return hitPercent / 100`
	`166`	`+ return max(hitPercent/100-attackTable.HitSuppression, 0)`
`168`	`167`	`}`
`169`	`168`	`func (spell Spell) PhysicalHitCheck(sim Simulation, attackTable *AttackTable) bool {`
`170`	`169`	`return sim.Proc(1.0-spell.GetPhysicalMissChance(attackTable), "Physical Hit Roll")`