Skip to content

Commit 29c0708

Browse files
committed
cleanup
1 parent 548a611 commit 29c0708

2 files changed

Lines changed: 7 additions & 11 deletions

File tree

autotest/test_prt_clamp.py

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,5 @@
11
"""
2-
Subcell tracking methods "snap" particles to whichever (sub)cell they're
3-
assigned to. This is both a separation of concerns (the tracking methods
4-
can be kept smaller/simpler, avoiding redundant logic to cross-check the
5-
cell ID against the particle's coordinates) and a user-facing feature: a
6-
particle released close to a cell boundary may be determined invalid due
7-
to floating point imprecision, by default, so the user may choose to set
8-
COORDINATE_CHECK_METHOD NONE to tolerate particles ending up outside the
9-
cells they are assigned to. This is effectively a "snap to cell" feature.
10-
11-
These test cases exercise this "snap" or "clamp" behavior in lateral and
2+
These test cases exercise cell "snap" or "clamp" behavior in lateral and
123
vertical dimensions. There is currently no distance limit; particles may
134
begin arbitrarily far outside the cell.
145

doc/ReleaseNotes/develop.toml

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -253,5 +253,10 @@ description = "The groundwater cell number written to the binary budget file for
253253

254254
[[items]]
255255
section = "fixes"
256-
subsection = "advanced"
256+
subsection = "model"
257257
description = "The PRT model's Particle Release Point (PRP) package performs release point validation using a point-in-polygon test that compares raw coordinates for exact floating point equality. This could incorrectly flag points close to a cell boundary as outside the cell, especially for rotated cells or cells with very large coordinate values. Add a small tolerance to the containment check, scaled to the cell's extent, to reduce the odds that a point will fail the check due to numerical inexactness."
258+
259+
[[items]]
260+
section = "fixes"
261+
subsection = "model"
262+
description = "The PRT model did not consistently clamp particle coordinates to the extent of the cell before applying the tracking method. This could cause an incorrect exit face or travel time solution, for example due to roundoff in the coordinate transformations computed as the particle moves between cells. This has been corrected; coordinates will now be clamped to the cell boundary in all dimensions. Results may change slightly for models with particle positions lying close to cell boundaries."

0 commit comments

Comments
 (0)