Skip to content

Add Alternative LC3 Executor and I/O Implementations #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

Add Alternative LC3 Executor and I/O Implementations #10

wants to merge 9 commits into from

Conversation

@Bennett-Petzold
Copy link
Collaborator

@Bennett-Petzold Bennett-Petzold commented Jan 23, 2025

No description provided.

@Bennett-Petzold
Add LC3 with separate data and instruction lanes
331d774 
The two lanes actually improves performance compared to the base design.
github-advanced-security[bot]
github-advanced-security bot found potential problems Mar 30, 2025
View reviewed changes
src/executors/mod.rs
instruction::{Instruction, InstructionEnum, InstructionErr, InsufficientPerms},
defs::{
HalfLC3Word, LC3MemAddr, LC3Word, RegAddr, DISPLAY_DATA_REGISTER, DISPLAY_STATUS_REGISTER,
KEYBOARD_DATA_REGISTER, KEYBOARD_INTERRUPT, KEYBOARD_STATUS_REGISTER, STACK_REG,

Check warning

Code scanning / clippy

unused imports: IJumpSubRoutine and KEYBOARD_INTERRUPT Warning

unused imports: IJumpSubRoutine and KEYBOARD_INTERRUPT
src/executors/mod.rs
KEYBOARD_DATA_REGISTER, KEYBOARD_INTERRUPT, KEYBOARD_STATUS_REGISTER, STACK_REG,
},
instruction::{
IJumpSubRoutine, Instruction, InstructionEnum, InstructionErr, InsufficientPerms,

Check warning

Code scanning / clippy

unused imports: IJumpSubRoutine and KEYBOARD_INTERRUPT Warning

unused imports: IJumpSubRoutine and KEYBOARD_INTERRUPT
src/harnesses/general.rs
@@ -0,0 +1,46 @@
//! Generically defined executors
use std::future::{ready, Ready};

Check warning

Code scanning / clippy

unused imports: Ready and ready Warning

unused imports: Ready and ready
src/harnesses/general.rs
@@ -0,0 +1,46 @@
//! Generically defined executors
use std::future::{ready, Ready};

Check warning

Code scanning / clippy

unused imports: Ready and ready Warning

unused imports: Ready and ready
src/harnesses/general.rs

use crate::{
executors::LC3,
instruction::{InstructionEnum, Trap},

Check warning

Code scanning / clippy

unused imports: InstructionEnum and Trap Warning

unused imports: InstructionEnum and Trap
src/harnesses/general.rs

use crate::{
executors::LC3,
instruction::{InstructionEnum, Trap},

Check warning

Code scanning / clippy

unused imports: InstructionEnum and Trap Warning

unused imports: InstructionEnum and Trap
src/harnesses/general.rs
instruction::{InstructionEnum, Trap},
};

use super::{r#async::AsyncHarness, sync::SyncHarness, ExecutionFailure};

Check warning

Code scanning / clippy

unused import: r#async::AsyncHarness Warning

unused import: r#async::AsyncHarness
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Bennett-Petzold