Check PayPal post var is not empty before using it

clavaque · clavaque · commit 2c2889a6317c · 2020-12-03T04:37:08.000+01:00
diff --git a/src/includes/classes/paypal-utilities.inc.php b/src/includes/classes/paypal-utilities.inc.php
@@ -61,9 +61,11 @@ public static function paypal_postvars()
 											{
 												foreach(preg_split("/[\r\n]+/", preg_replace("/^SUCCESS/i", "", $response)) as $varline)
 													{
-														list($key, $value) = preg_split("/\=/", $varline, 2);
-														if(strlen($key = trim($key)) && strlen($value = trim($value)))
-															$postvars[$key] = trim(stripslashes(urldecode($value)));
+														if (!empty($varline)) {
+															list($key, $value) = preg_split("/\=/", $varline, 2);
+															if (strlen($key = trim($key)) && strlen($value = trim($value)))
+																$postvars[$key] = trim(stripslashes(urldecode($value)));
+														}
 													}
 												$postvars = self::paypal_postvars_back_compat($postvars); // From verified data.
 

Original file line number	Diff line number	Diff line change
`@@ -61,9 +61,11 @@ public static function paypal_postvars()`
`61`	`61`	`{`
`62`	`62`	`foreach(preg_split("/[\r\n]+/", preg_replace("/^SUCCESS/i", "", $response)) as $varline)`
`63`	`63`	`{`
`64`		`- list($key, $value) = preg_split("/\=/", $varline, 2);`
`65`		`- if(strlen($key = trim($key)) && strlen($value = trim($value)))`
`66`		`- $postvars[$key] = trim(stripslashes(urldecode($value)));`
	`64`	`+ if (!empty($varline)) {`
	`65`	`+ list($key, $value) = preg_split("/\=/", $varline, 2);`
	`66`	`+ if (strlen($key = trim($key)) && strlen($value = trim($value)))`
	`67`	`+ $postvars[$key] = trim(stripslashes(urldecode($value)));`
	`68`	`+ }`
`67`	`69`	`}`
`68`	`70`	`$postvars = self::paypal_postvars_back_compat($postvars); // From verified data.`
`69`	`71`