Skip to content

Commit 96b7ca4

Browse files
authored
bug fix for TEMPO and aer_opt=3 combination (#2302)
This PR fixes a crash when TEMPO is run in combination with aer_opt=3 TYPE: bug fix KEYWORDS: TEMPO, aer_opt=3 SOURCE: Joseph Olson (NOAA-GSL) DESCRIPTION OF CHANGES: Problem: Model crashes because two arrays are left unallocated Solution: 1. Include taod5503d and taod5502d in the tempo_aerosolaware package 2. Add a safety check in module_check_a_mundo.F to guard against misconfigurations LIST OF MODIFIED FILES: list of changed files (use `git diff --name-status develop` to get formatted list) M Registry/Registry.EM_COMMON M share/module_check_a_mundo.F TESTS CONDUCTED: 1. Do mods fix problem? Yes. Testing in single case study. 2. Are the Jenkins tests all passing?
1 parent 3fd1ed7 commit 96b7ca4

2 files changed

Lines changed: 13 additions & 1 deletion

File tree

Registry/Registry.EM_COMMON

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3109,7 +3109,7 @@ package nssl_graupelvol nssl_density_on==1 - scalar:qvol
31093109
package nssl_hailvol nssl_density_on==2 - scalar:qvolg,qvolh
31103110
package nssl_ssat_out nssl_ssat_output==1 - state:ssat
31113111
package nssl_ssati_out nssl_ssat_output==2 - state:ssat,ssati
3112-
package tempo_aerosol tempo_aerosolaware==1 - scalar:qnc,qnwfa,qnifa;state:qnwfa2d,qnifa2d
3112+
package tempo_aerosol tempo_aerosolaware==1 - scalar:qnc,qnwfa,qnifa;state:qnwfa2d,qnifa2d,taod5503d,taod5502d
31133113
package tempo_hail tempo_hailaware==1 - scalar:qng,qvolg
31143114

31153115
package radar_refl compute_radar_ref==1 - state:refl_10cm,refd_max

share/module_check_a_mundo.F

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2559,6 +2559,18 @@ END FUNCTION bep_bem_ngr_u
25592559
END IF
25602560
END DO
25612561

2562+
!-----------------------------------------------------------------------
2563+
! If aer_opt=3 and TEMPO (mp_physics=88), need to use tempo_aerosolaware = 1
2564+
!-----------------------------------------------------------------------
2565+
DO i = 1, model_config_rec % max_dom
2566+
IF ( model_config_rec%mp_physics(i) .EQ. TEMPO .AND. model_config_rec%aer_opt .EQ. 3 .AND. &
2567+
model_config_rec%tempo_aerosolaware .EQ. 0) THEN
2568+
model_config_rec%tempo_aerosolaware = 1
2569+
wrf_err_message = '--- WARNING: For TEMPO & aer_opt=3, tempo_aerosolaware must = 1'
2570+
CALL wrf_debug ( 0, TRIM( wrf_err_message ) )
2571+
END IF
2572+
END DO
2573+
25622574
!-----------------------------------------------------------------------
25632575
! Set aer_fire_emit_opt for Thompson-MP-Aero (mp_physics=28) AND rcon mp (mp_physics=29)
25642576
!-----------------------------------------------------------------------

0 commit comments

Comments
 (0)