Skip to content

Commit 203ee28

Browse files
authored
Merge pull request #885 from writer/codex/find-and-fix-a-bug-in-codebase
fix: Handle empty IP in Basic Auth
2 parents 9d37b6a + 3863ca3 commit 203ee28

1 file changed

Lines changed: 6 additions & 1 deletion

File tree

src/writer/auth.py

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -405,6 +405,11 @@ def _client_ip(request: Request) -> str:
405405
ip = x_forwarded_for.split(",")[0].strip()
406406
else:
407407
# Otherwise, use the direct connection IP
408-
ip = request.headers.get("X-Real-IP", request.client.host) # type: ignore
408+
x_real_ip = request.headers.get("X-Real-IP")
409+
if x_real_ip is not None:
410+
ip = x_real_ip
411+
else:
412+
client = request.client
413+
ip = client.host if client is not None else ""
409414

410415
return ip

0 commit comments

Comments
 (0)