Skip to content

Commit 66cdc60

Browse files
committed
fix(ui): setup type="button" for WdsButtonLink
Without `type="button"`, the button is considerated as a Submit button, which sends the parent form and produce a page reloading
1 parent fdf9fa0 commit 66cdc60

4 files changed

Lines changed: 4 additions & 4 deletions

File tree

src/ui/src/wds/WdsButton.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
<button
33
class="WdsButton colorTransformer"
44
:class="className"
5-
role="button"
5+
type="button"
66
:style="style"
77
:disabled="disabled || loading"
88
>

src/ui/src/wds/WdsButtonLink.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
class="WdsButtonLink"
44
:disabled="disbaled"
55
:class="className"
6-
role="button"
6+
type="button"
77
>
88
<i v-if="leftIcon" class="material-symbols-outlined">{{ leftIcon }}</i>
99
<span class="WdsButtonLink__text">{{ text }}</span>

src/ui/src/wds/WdsDropdownMenu.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
</div>
1414
<button
1515
class="WdsDropdownMenu__header__multiSelect__clear"
16-
role="button"
16+
type="button"
1717
@click="$emit('select', [])"
1818
>
1919
Clear all

src/ui/src/wds/WdsTag.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ defineEmits({
2727
<span class="WdsTag__text">{{ text }}</span>
2828
<button
2929
v-if="closable"
30-
role="button"
30+
type="button"
3131
class="WdsTag__close"
3232
@click.stop="$emit('close')"
3333
>

0 commit comments

Comments
 (0)