Skip to content

Commit 1e3152b

Browse files
Merge pull request #12 from BiyonFernando/master
Address comments
2 parents a33b399 + 9d62a15 commit 1e3152b

3 files changed

Lines changed: 8 additions & 6 deletions

File tree

.github/workflows/pr-builder.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ jobs:
2626
distribution: "adopt"
2727
- name: Cache local Maven repository
2828
id: cache-maven-m2
29-
uses: actions/cache@v2
29+
uses: actions/cache@v4
3030
env:
3131
cache-name: cache-m2
3232
with:

README.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
### Step 2: Configure HashiCorp Vault extension
2525

2626
1. Build the HashiCorp Vault Integration OSGI bundle using `mvn clean install` and copy
27-
the `target/org.wso2.carbon.securevault.hashicorp-1.0.jar` file to `<IS_HOME>/repository/components/dropin/`
27+
the `target/org.wso2.carbon.securevault.hashicorp-1.0.jar` file to `<IS_HOME>/repository/components/dropins/`
2828
directory.
2929

3030
2. Add **HashiCorp Vault Java Driver** (Eg: `vault-java-driver-5.1.0.jar`) to the
@@ -133,7 +133,7 @@ The file should be named according to your Operating System.
133133
}
134134
```
135135
136-
Upload kv policy as bellow
136+
Upload kv policy as below
137137
138138
```
139139
vault policy write kv-read-write kv-read-write.hcl
@@ -153,12 +153,12 @@ The file should be named according to your Operating System.
153153
token_max_ttl="72h"
154154
```
155155
156-
Get the role-id as bellow
156+
Get the role-id as below
157157
```
158158
vault read auth/approle/role/my-role/role-id
159159
```
160160
161-
Get the secret-id as bellow
161+
Get the secret-id as below
162162
163163
```
164164
vault write -f auth/approle/role/my-role/secret-id
@@ -182,7 +182,7 @@ The file should be named according to your Operating System.
182182
### Step 2: Configure HashiCorp Vault extension
183183
184184
1. Build the HashiCorp Vault Integration OSGI bundle using `mvn clean install` and copy
185-
the `target/org.wso2.carbon.securevault.hashicorp-1.0.jar` file to `<IS_HOME>/repository/components/dropin/`
185+
the `target/org.wso2.carbon.securevault.hashicorp-1.0.jar` file to `<IS_HOME>/repository/components/dropins/`
186186
directory.
187187
188188
2. Add **HashiCorp Vault Java Driver** (Eg: `vault-java-driver-5.1.0.jar`) to the

pom.xml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818
<plugin>
1919
<groupId>org.apache.felix</groupId>
2020
<artifactId>maven-bundle-plugin</artifactId>
21+
<version>${maven.bundle.plugin.version}</version>
2122
<extensions>true</extensions>
2223
<configuration>
2324
<instructions>
@@ -83,6 +84,7 @@
8384
<maven.compiler.target>1.8</maven.compiler.target>
8485

8586
<jacoco.version>0.8.12</jacoco.version>
87+
<maven.bundle.plugin.version>3.2.0</maven.bundle.plugin.version>
8688
</properties>
8789

8890
<dependencies>

0 commit comments

Comments
 (0)