Merge pull request #7894 from PasinduYeshan/fix/sms-resend-attemp

Provide UI support for configuring SmsOTP.ResendAttemptsCount

Author: PasinduYeshan

Diff for: .changeset/moody-phones-share.md

@@ -0,0 +1,7 @@
+---
+"@wso2is/admin.identity-providers.v1": patch
+"@wso2is/console": patch
+"@wso2is/i18n": patch
+---
+
+Add SMS otp authenticator resend attempt config to UI

Diff for: features/admin.identity-providers.v1/components/forms/authenticators/sms-otp-authenticator-form.tsx

@@ -494,12 +494,11 @@ export const SMSOTPAuthenticatorForm: FunctionComponent<SMSOTPAuthenticatorFormP
                     }
                 </Label>
             </Field.Input>
-            { /* TODO: Uncomment resend attempt count field once it's finalized.
-
             <Field.Input
                 ariaLabel="Allowed Resend Attempts"
                 inputType="number"
                 name="SmsOTP_ResendAttemptsCount"
+                labelPosition="right"
                 label={
                     t("authenticationProvider:forms.authenticatorSettings" +
                         ".smsOTP.allowedResendAttemptCount.label")
@@ -521,21 +520,33 @@ export const SMSOTPAuthenticatorForm: FunctionComponent<SMSOTPAuthenticatorFormP
                 }
                 required={ true }
                 readOnly={ readOnly }
+                max={
+                    ConnectionUIConstants
+                        .SMS_OTP_AUTHENTICATOR_SETTINGS_FORM_FIELD_CONSTRAINTS.ALLOWED_RESEND_ATTEMPT_COUNT_MAX_VALUE
+                }
+                min={
+                    ConnectionUIConstants
+                        .SMS_OTP_AUTHENTICATOR_SETTINGS_FORM_FIELD_CONSTRAINTS.ALLOWED_RESEND_ATTEMPT_COUNT_MIN_VALUE
+                }
                 maxLength={
-                    IdentityProviderManagementConstants
+                    ConnectionUIConstants
                         .SMS_OTP_AUTHENTICATOR_SETTINGS_FORM_FIELD_CONSTRAINTS.ALLOWED_RESEND_ATTEMPT_COUNT_MAX_LENGTH
                 }
                 minLength={
-                    IdentityProviderManagementConstants
+                    ConnectionUIConstants
                         .SMS_OTP_AUTHENTICATOR_SETTINGS_FORM_FIELD_CONSTRAINTS.ALLOWED_RESEND_ATTEMPT_COUNT_MIN_LENGTH
                 }
                 width={ 12 }
                 data-testid={ `${ testId }-allowed-resend-attempt-count` }
             >
                 <input />
+                <Label>
+                    {
+                        t("authenticationProvider:forms.authenticatorSettings" +
+                            ".smsOTP.allowedResendAttemptCount.unit")
+                    }
+                </Label>
             </Field.Input>
-
-            */ }
             <Field.Button
                 form={ FORM_ID }
                 size="small"

Diff for: modules/i18n/src/models/namespaces/authentication-provider-ns.ts

@@ -334,6 +334,7 @@ export interface AuthenticationProviderNS {
                     hint: string;
                     label: string;
                     placeholder: string;
+                    unit: string;
                     validations: {
                         required: string;
                         invalid: string;

Diff for: modules/i18n/src/translations/en-US/portals/authentication-provider.ts

@@ -813,6 +813,7 @@ export const authenticationProvider:AuthenticationProviderNS = {
                     hint: "The number of allowed OTP resend attempts.",
                     label: "Allowed OTP resend attempt count",
                     placeholder: "Enter allowed resend attempt count.",
+                    unit: "attempts",
                     validations: {
                         invalid: "Allowed OTP resend attempt count should be an integer.",
                         range: "Allowed OTP resend attempt count should be between 0 & 100.",