Merge pull request #142 from sohomdatta1/chrome-139

Add support for Chrome 139

Author: sohomdatta1

builder/build-direct.sh

@@ -224,6 +224,28 @@ EOL
 
     chmod ugo+r /artifacts/$VERSION/ChromePublic-vv8-$VERSION.apk
 
+    cat >>out/Android/args.gn <<EOL
+target_os = "android"
+target_cpu = "arm64"
+system_webview_package_name = "com.google.android.webview.beta"
+enable_nacl=false
+dcheck_always_on=false
+is_debug=false
+disable_fieldtrial_testing_config=true
+is_official_build=true
+is_component_build = false
+use_thin_lto=false
+is_cfi=false
+chrome_pgo_phase=0
+v8_use_external_startup_data=true
+EOL
+    gn gen out/Android
+    autoninja -C out/Android system_webview_apk
+
+    cp -r out/Android/apks/SystemWebView.apk /artifacts/$VERSION/SystemWebView-vv8-$VERSION.apk
+
+    chmod ugo+r /artifacts/$VERSION/SystemWebView-vv8-$VERSION.apk
+
     rm -rf out/Android
 fi
 

patches/877e4fc9c2c55916e516/chrome-sandbox.patch

@@ -0,0 +1,217 @@
+From 6c1fa2d4d78ea83de486c33a613b58a65bd03bf0 Mon Sep 17 00:00:00 2001
+From: Sohom <sdatta4@ncsu.edu>
+Date: Wed, 13 Aug 2025 21:08:56 -0400
+Subject: [PATCH] VisibleV8 for 139
+
+---
+ .../base/process_launcher/BindService.java    |  2 +-
+ build/install-build-deps.py                   | 10 +++-
+ chrome/android/java/AndroidManifest.xml       |  4 +-
+ .../java/gin_java_method_invocation_helper.cc |  2 +
+ .../gin_java_function_invocation_helper.cc    | 46 ++++++++++++++++++-
+ content/renderer/renderer_main.cc             |  3 +-
+ .../modules/remote_objects/remote_object.cc   |  1 +
+ .../renderer/platform/bindings/v8_binding.h   |  1 +
+ 8 files changed, 62 insertions(+), 7 deletions(-)
+
+diff --git a/base/android/java/src/org/chromium/base/process_launcher/BindService.java b/base/android/java/src/org/chromium/base/process_launcher/BindService.java
+index c002b23dbe42e..fa5e777826fee 100644
+--- a/base/android/java/src/org/chromium/base/process_launcher/BindService.java
++++ b/base/android/java/src/org/chromium/base/process_launcher/BindService.java
+@@ -30,7 +30,7 @@ final class BindService {
+ 
+     static boolean supportVariableConnections() {
+         return Build.VERSION.SDK_INT >= Build.VERSION_CODES.Q
+-                && !BuildConfig.IS_INCREMENTAL_INSTALL;
++                && !true;  // VisibleV8 android change required disabling renderer isolation.
+     }
+ 
+     // Note that handler is not guaranteed to be used, and client still need to correctly handle
+diff --git a/build/install-build-deps.py b/build/install-build-deps.py
+index 412962fedf4c8..618b59ea17332 100755
+--- a/build/install-build-deps.py
++++ b/build/install-build-deps.py
+@@ -862,8 +862,16 @@ def install_packages(options):
+   try:
+     packages = find_missing_packages(options)
+     if packages:
++      env = os.environ.copy()
++      env["LANGUAGE"] = "en"
++      env["LANG"] = "C"
++      env["DEBIAN_FRONTEND"] = 'noninteractive'
+       quiet = ["-qq", "--assume-yes"] if options.no_prompt else []
+-      subprocess.check_call(["sudo", "apt-get", "install"] + quiet + packages)
++      if options.no_prompt:
++        subprocess.check_call(["sudo", "-E", "apt-get", "install"] + quiet + packages, env=env)
++      else:
++        subprocess.check_call(["sudo", "apt-get", "install"] + quiet + packages)
++
+       print(file=sys.stderr)
+     else:
+       print("No missing packages, and the packages are up to date.",
+diff --git a/chrome/android/java/AndroidManifest.xml b/chrome/android/java/AndroidManifest.xml
+index 40da3e5ffeab7..76e68a1e57845 100644
+--- a/chrome/android/java/AndroidManifest.xml
++++ b/chrome/android/java/AndroidManifest.xml
+@@ -1240,13 +1240,13 @@ by a child template that "extends" this file.
+       <service android:name="org.chromium.content.app.SandboxedProcessService{{ i }}"
+           android:process=":sandboxed_process{{ i }}"
+           android:permission="{{ manifest_package }}.permission.CHILD_SERVICE"
+-          android:isolatedProcess="true"
++          android:isolatedProcess="false"
+           android:exported="{{sandboxed_service_exported|default(false)}}"
+           {% if (i == 0) %}
+           android:useAppZygote="true"
+           {% endif %}
+           {% if (sandboxed_service_exported|default(false)) == 'true' %}
+-          android:externalService="true"
++          android:externalService="false"
+           tools:ignore="ExportedService"
+           android:visibleToInstantApps="true"
+           {% endif %} />
+diff --git a/content/browser/android/java/gin_java_method_invocation_helper.cc b/content/browser/android/java/gin_java_method_invocation_helper.cc
+index 719faf03919fa..2811c11c26cc0 100644
+--- a/content/browser/android/java/gin_java_method_invocation_helper.cc
++++ b/content/browser/android/java/gin_java_method_invocation_helper.cc
+@@ -12,6 +12,8 @@
+ #include "base/android/event_log.h"
+ #include "base/android/jni_android.h"
+ #include "base/android/jni_string.h"
++#include "base/logging.h"
++#include "base/debug/stack_trace.h"
+ #include "content/browser/android/java/gin_java_script_to_java_types_coercion.h"
+ #include "content/browser/android/java/java_method.h"
+ #include "content/common/android/gin_java_bridge_value.h"
+diff --git a/content/renderer/java/gin_java_function_invocation_helper.cc b/content/renderer/java/gin_java_function_invocation_helper.cc
+index 124d40ab0e419..116ff2c0cd221 100644
+--- a/content/renderer/java/gin_java_function_invocation_helper.cc
++++ b/content/renderer/java/gin_java_function_invocation_helper.cc
+@@ -14,6 +14,7 @@
+ #include "content/renderer/java/gin_java_bridge_object.h"
+ #include "content/renderer/java/gin_java_bridge_value_converter.h"
+ #include "v8/include/v8-exception.h"
++#include "v8/include/v8-visiblev8.h"
+ 
+ namespace content {
+ 
+@@ -79,6 +80,13 @@ v8::Local<v8::Value> GinJavaFunctionInvocationHelper::Invoke(
+     }
+   }
+ 
++  std::vector<v8::Local<v8::Value>> visv8_args;
++
++  v8::Local<v8::Value> val;
++  while (args->GetNext(&val)) {
++    visv8_args.push_back(val);
++  }
++
+   mojom::GinJavaBridgeError error =
+       mojom::GinJavaBridgeError::kGinJavaBridgeNoError;
+ 
+@@ -95,12 +103,24 @@ v8::Local<v8::Value> GinJavaFunctionInvocationHelper::Invoke(
+     }
+   }
+   if (!result.get()) {
++    auto* functionCallbackInfo = args->GetFunctionCallbackInfo();
++    v8::visv8_log_java_api_call(
++        args->isolate(), false, functionCallbackInfo->Data().As<v8::String>(),
++        functionCallbackInfo->This().As<v8::Object>(),
++        v8::Undefined(args->isolate()), visv8_args, visv8_args.size());
+     args->isolate()->ThrowException(v8::Exception::Error(gin::StringToV8(
+         args->isolate(), base::StrCat({"Error invoking ", method_name_, ": ",
+                                        GinJavaBridgeErrorToString(error)}))));
+     return v8::Undefined(args->isolate());
+   }
+   if (!result->is_blob()) {
++    auto* functionCallbackInfo = args->GetFunctionCallbackInfo();
++    v8::visv8_log_java_api_call(
++        args->isolate(), false, functionCallbackInfo->Data().As<v8::String>(),
++        functionCallbackInfo->This().As<v8::Object>(),
++        converter_->ToV8Value(result.get(),
++                              args->isolate()->GetCurrentContext()),
++        visv8_args, visv8_args.size());
+     return converter_->ToV8Value(result.get(),
+                                  args->isolate()->GetCurrentContext());
+   }
+@@ -116,15 +136,39 @@ v8::Local<v8::Value> GinJavaFunctionInvocationHelper::Invoke(
+     if (object_result) {
+       gin::Handle<GinJavaBridgeObject> controller =
+           gin::CreateHandle(args->isolate(), object_result);
+-      if (controller.IsEmpty())
++      if (controller.IsEmpty()) {
++        auto* functionCallbackInfo = args->GetFunctionCallbackInfo();
++        v8::visv8_log_java_api_call(
++            args->isolate(), false,
++            functionCallbackInfo->Data().As<v8::String>(),
++            functionCallbackInfo->This().As<v8::Object>(),
++            v8::Undefined(args->isolate()), visv8_args, visv8_args.size());
+         return v8::Undefined(args->isolate());
++      }
++      auto* functionCallbackInfo = args->GetFunctionCallbackInfo();
++      v8::visv8_log_java_api_call(
++          args->isolate(), false, functionCallbackInfo->Data().As<v8::String>(),
++          functionCallbackInfo->This().As<v8::Object>(), controller.ToV8(),
++          visv8_args, visv8_args.size());
+       return controller.ToV8();
+     }
+   } else if (gin_value->IsType(GinJavaBridgeValue::TYPE_NONFINITE)) {
+     float float_value;
+     gin_value->GetAsNonFinite(&float_value);
++    auto* functionCallbackInfo = args->GetFunctionCallbackInfo();
++    v8::visv8_log_java_api_call(args->isolate(), false,
++                                functionCallbackInfo->Data().As<v8::String>(),
++                                functionCallbackInfo->This().As<v8::Object>(),
++                                v8::Number::New(args->isolate(), float_value),
++                                visv8_args, visv8_args.size());
+     return v8::Number::New(args->isolate(), float_value);
+   }
++
++  auto* functionCallbackInfo = args->GetFunctionCallbackInfo();
++  v8::visv8_log_java_api_call(
++      args->isolate(), false, functionCallbackInfo->Data().As<v8::String>(),
++      functionCallbackInfo->This().As<v8::Object>(),
++      v8::Undefined(args->isolate()), visv8_args, visv8_args.size());
+   return v8::Undefined(args->isolate());
+ }
+ 
+diff --git a/content/renderer/renderer_main.cc b/content/renderer/renderer_main.cc
+index 1613e02e24fab..efa5ef53c422d 100644
+--- a/content/renderer/renderer_main.cc
++++ b/content/renderer/renderer_main.cc
+@@ -229,8 +229,7 @@ int RendererMain(MainFunctionParams parameters) {
+   {
+     content::ContentRendererClient* client = GetContentClient()->renderer();
+     bool should_run_loop = true;
+-    bool need_sandbox =
+-        !command_line.HasSwitch(sandbox::policy::switches::kNoSandbox);
++    bool need_sandbox = false; // VisibleV8 disable sandbox for desktop
+ 
+     if (!need_sandbox) {
+       // The post-sandbox actions still need to happen at some point.
+diff --git a/third_party/blink/renderer/modules/remote_objects/remote_object.cc b/third_party/blink/renderer/modules/remote_objects/remote_object.cc
+index 596c63d91183e..1e7585231c6a8 100644
+--- a/third_party/blink/renderer/modules/remote_objects/remote_object.cc
++++ b/third_party/blink/renderer/modules/remote_objects/remote_object.cc
+@@ -6,6 +6,7 @@
+ 
+ #include <tuple>
+ 
++#include "base/logging.h"
+ #include "base/numerics/safe_conversions.h"
+ #include "gin/converter.h"
+ #include "third_party/blink/public/web/blink.h"
+diff --git a/third_party/blink/renderer/platform/bindings/v8_binding.h b/third_party/blink/renderer/platform/bindings/v8_binding.h
+index 4c7d81cd06492..bd023d9841c10 100644
+--- a/third_party/blink/renderer/platform/bindings/v8_binding.h
++++ b/third_party/blink/renderer/platform/bindings/v8_binding.h
+@@ -50,6 +50,7 @@
+ #include "v8/include/v8-maybe.h"
+ #include "v8/include/v8-persistent-handle.h"
+ #include "v8/include/v8-primitive.h"
++#include "v8/include/v8-visiblev8.h"
+ #include "v8/include/v8-value.h"
+ 
+ namespace blink {
+-- 
+2.43.0
+