Skip to content

Commit 8a7bc46

Browse files
author
Wiktor Jurczyszyn
committed
#371 fixing styles + moving note-editor icon
1 parent ab49f46 commit 8a7bc46

File tree

5 files changed

+28
-23
lines changed

5 files changed

+28
-23
lines changed

report/src/main/webapp/app/layout/main/url/navigation/navigation.patternButtons.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
limitations under the License.
1818
1919
-->
20-
<div class="toolbar-btns pull-right" data-ng-if=" case.usesCrossSuitePattern ">
20+
<div class="toolbar-button pull-right" data-ng-if=" case.usesCrossSuitePattern ">
2121
<div class="button button-small button-dark button-disabled"
2222
ng-if="case.showAcceptButton"
2323
data-aet-included-comment-popover
@@ -29,7 +29,7 @@
2929
Accept test case
3030
</div>
3131
</div>
32-
<div class="toolbar-btns pull-right" data-ng-if=" !case.usesCrossSuitePattern ">
32+
<div class="toolbar-button pull-right" data-ng-if=" !case.usesCrossSuitePattern ">
3333
<div id="accept-test-case" class="button button-small js-test-rebase button-blue" ng-click="urlView.acceptCase(case)"
3434
ng-if="case.showAcceptButton">
3535
<i class="icon icon-rebase"></i>

report/src/main/webapp/app/layout/main/url/reports/screen_layout.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,8 @@
3434
<div class="advanced-screen-comparison button button-small button-blue">
3535
<a ng-if="case.status == 'FAILED' || case.status == 'CONDITIONALLY_PASSED'" data-ng-click="advancedScreenComparison()" data-aet-compare-screens>Advanced Screen Comparison</a>
3636
</div>
37-
<ng-include src="'app/layout/main/url/navigation/navigation.comments.html'"/>
3837
<ng-include src="'app/layout/main/url/navigation/navigation.patternButtons.html'"/>
38+
<ng-include src="'app/layout/main/url/navigation/navigation.comments.html'"/>
3939
</div>
4040
</div>
4141
</div>

report/src/main/webapp/app/layout/toolbar/toolbarBottom.view.html

Lines changed: 16 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ <h4 class="toolbar-link-header ellipsis">
2828
data-ng-click="toolbarBottom.scrollSidepanel(false)">
2929
<i class="fas fa-crosshairs fa-sm"></i>
3030
</div>
31-
<div
31+
<div
3232
ng-if="toolbarBottom.viewMode != 'suite' && toolbarBottom.viewMode != 'test' && toolbarBottom.isLastSuiteVersion"
3333
class="fontawesome-link"
3434
data-toggle="popover"
@@ -114,19 +114,6 @@ <h5 ng-if="toolbarBottom.viewMode == 'url'">
114114
</div>
115115
</a>
116116
</div>
117-
<span class="comments-status pull-left"
118-
data-toggle="popover"
119-
data-ng-class="toolbarBottom.model.comment ? 'present' : 'absent'"
120-
data-content="{{toolbarBottom.model.comment && '<span>' + toolbarBottom.model.comment + '</span>' || !toolbarBottom.model.comment && '<span>Click to update this ' + toolbarBottom.viewMode + ' note</span>'}}"
121-
data-html="true" data-trigger="hover"
122-
data-ng-click="toolbarBottom.displayCommentModal()">
123-
<div ng-if="toolbarBottom.model.comment">
124-
<i class="fas fa-ellipsis-h" data-fa-transform="shrink-10 up-.5" data-fa-mask="fas fa-comment"></i>
125-
</div>
126-
<div ng-if="!toolbarBottom.model.comment">
127-
<i class="fas fa-pencil-alt" data-fa-transform="shrink-10 up-.5" data-fa-mask="fas fa-comment"></i>
128-
</div>
129-
</span>
130117

131118
<span class="button button-dark button-disabled"
132119
data-ng-if="toolbarBottom.usesCrossSuitePattern"
@@ -137,7 +124,7 @@ <h5 ng-if="toolbarBottom.viewMode == 'url'">
137124
data-trigger="hover"></i>
138125
Accept {{toolbarBottom.viewMode}}
139126
</span>
140-
127+
141128
<span id="accept-test" class="button js-rebase-suite button-blue"
142129
data-ng-if="toolbarBottom.showAcceptButton()"
143130
data-ng-click="toolbarBottom.updatePatterns()"></i>
@@ -150,6 +137,20 @@ <h5 ng-if="toolbarBottom.viewMode == 'url'">
150137
<i class="fas {{theme.statusClasses['unrebased']}}"></i>
151138
Revert {{toolbarBottom.viewMode}}
152139
</span>
140+
141+
<span class="comments-status pull-left"
142+
data-toggle="popover"
143+
data-ng-class="toolbarBottom.model.comment ? 'present' : 'absent'"
144+
data-content="{{toolbarBottom.model.comment && '<span>' + toolbarBottom.model.comment + '</span>' || !toolbarBottom.model.comment && '<span>Click to update this ' + toolbarBottom.viewMode + ' note</span>'}}"
145+
data-html="true" data-trigger="hover"
146+
data-ng-click="toolbarBottom.displayCommentModal()">
147+
<div ng-if="toolbarBottom.model.comment">
148+
<i class="fas fa-ellipsis-h" data-fa-transform="shrink-10 up-.5" data-fa-mask="fas fa-comment"></i>
149+
</div>
150+
<div ng-if="!toolbarBottom.model.comment">
151+
<i class="fas fa-pencil-alt" data-fa-transform="shrink-10 up-.5" data-fa-mask="fas fa-comment"></i>
152+
</div>
153+
</span>
153154
</div>
154155
</div>
155156
</div>

report/src/main/webapp/assets/sass/_test.scss

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@
3939
color: #77777c;
4040
font-size: 11px;
4141
display: inline-block;
42-
padding: 0 20px;
42+
padding-right: 20px;
4343
line-height: 31px;
4444
margin: 8px 0;
4545
vertical-align: middle;
@@ -53,7 +53,7 @@
5353
margin: 0;
5454
height: 20px;
5555
vertical-align: middle;
56-
56+
5757
.checkbox {
5858
display: inline-block;
5959
margin: 0;

report/src/main/webapp/assets/sass/_toolbar.scss

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -216,12 +216,11 @@
216216

217217
.button {
218218
float: left;
219-
margin-left: 15px;
219+
margin-right: 15px;
220220
}
221221

222222
.tab-content-toolbar & {
223223
padding-top: 3px;
224-
padding-right: 15px;
225224
height: 47px;
226225
}
227226
}
@@ -233,7 +232,7 @@
233232
display: block;
234233
line-height: 44px;
235234
cursor: pointer;
236-
margin-right: 10px;
235+
margin: -3px 0 0 10px;
237236

238237
&.small {
239238
line-height: 37px;
@@ -250,6 +249,7 @@
250249
}
251250

252251
.tab-content-toolbar {
252+
padding: 0 20px;
253253

254254
@media (max-width: 1300px) {
255255
height: 94px;
@@ -262,6 +262,10 @@
262262
.toolbar-blocks {
263263
display: inline;
264264
}
265+
266+
.toolbar-button {
267+
margin-top: 3px;
268+
}
265269
}
266270

267271
.set-initial-font-size {

0 commit comments

Comments
 (0)