More mutagen optimization

[kekkis]

Based on running ddev utility mutagen-diagnose on multiple projects, it seems some additions might be useful for our default setup for upload_dirs. The ones that are default for most projects are:

- ../node_modules
- sites/default/files

Also I would like to be able to exclude the node_modules directory in the custom themes but since the name of the theme is unique in most projects it is hard to hard-code it correctly. So instead I would suggest adding a section about the optimization to the README of this project, in the installation section for example.

[hkirsman]

I didn't know this setting https://github.com/wunderio/ddev-wunderio-drupal/blob/main/config.wunderio.yaml#L38 would be override defaults so sites/default/files needs to be put back for sure.

But not sure about node_modules. I heard sometimes it's needed so how do you enable again? @Tromppa what do you think?

[hkirsman]

I've created PR here #52

[kekkis]

But not sure about node_modules. I heard sometimes it's needed so how do you enable again?

I don't think node_modules need to be mutagen-synced from the theme at least, since they are not used in other ways than to build the bundles or to run other one-time commands.

[kekkis]

I didn't know this setting https://github.com/wunderio/ddev-wunderio-drupal/blob/main/config.wunderio.yaml#L38 would be override defaults so sites/default/files needs to be put back for sure.

Also about this: there is no default setting for upload_dirs when you first set up a fresh ddev environment. Therefore it is safe to add also per-project in the default config.yaml but as I mentioned in the PR comments, I think it would make sense for use to include this in this add-on since this deals with Drupal development.

[Tromppa]

@hkirsman yes we had problems with some npm commands stop working after the mutagen ignore contained node_modules, but that was for NextJS, so might be Drupal theme one is different.
We just have some like these in the mutagen.yml file:

sync:
  defaults:
    mode: "two-way-resolved"
    stageMode: "neighboring"
    ignore:
      paths:
        # The top-level .git directory is ignored because where possible it's
        # mounted into the container with a traditional docker bind-mount
        - "/database_dumps"
        - "/next/.next"
        - "/drupal/web/sites/default/files"
        - "/drupal/web/sites/fortum-com/files"
        - "/drupal/web/sites/fortum-fi/files"

[hkirsman]

I have been testing today this setting and benchmarking and one time startup goes slower, then next restart it's fast again. So I was already thinking I've got this all wrong, there doesn't seem to be any pattern or rule how it behaves. Does it even help at all. I was testing in project .ddev/config.yaml - removing and adding ../database_dumpand ../node_modules. But now I think I understand what's the cause - yes the particular config is overwritten, but only DDEV default - local yml files are combined - at least for this particular setting. We have wunderio/ddev-wunderio-drupal default .ddev/config.wunderio.yaml and project specific .ddev/config.yaml. So removing ../database_dump fromfrom .ddev/config.yaml doesn't do anything as it's still in .ddev/config.wunderio.yaml.

After removing ../database_dump from both files and having lots of db dumps in that folder:
Before:

After:

And after also removing node_modules from the options, size grew to 24.1 (not much, but lot of files):

Regarding defaults, not sure if I understood correctly, but sites/default/files is in the default Drupal recipe. We are just overwriting it.

@Tromppa in your project, was the node_modules in your .ddev/config.yaml- I'm wondering how it got there if we haven't added it from here yet.

All in all I'm a bit hesitant to add ../node_modules yet because of that particular issue. I'd maybe try first for week or 2.