Avoid false field initializer warnings for initialized receivers

Author: Frotty

de.peeeq.wurstscript/src/main/java/de/peeeq/wurstscript/validation/WurstValidator.java

@@ -2008,6 +2008,7 @@ private void checkField(NameRef access) {
                 if (!(nameDef instanceof GlobalVarDef referenced)
                     || !referenced.attrIsDynamicClassMember()
                     || !(referenced.getInitialExpr() instanceof NoExpr)
+                    || (!isCurrentInstanceAccess(access) && hasGuaranteedConstructorAssignment(referenced))
                     || !warned.add(referenced)) {
                     return;
                 }

de.peeeq.wurstscript/src/test/java/tests/wurstscript/tests/ClassesTests.java

@@ -257,6 +257,27 @@ public void doesNotTreatDeferredClosureInitializerAsImmediateFieldRead() {
             result.getGui().getWarningList().toString());
     }
 
+    @Test
+    public void doesNotWarnForExplicitReceiverWithGuaranteedConstructorAssignment() {
+        CompilationResult result = test()
+            .setStopOnFirstError(false)
+            .executeProg(false)
+            .lines(
+                "package Test",
+                "class Source",
+                "    int value",
+                "    construct()",
+                "        value = 1",
+                "class Holder",
+                "    Source source = new Source()",
+                "    int copy = source.value"
+            );
+
+        assertFalse(result.getGui().getWarningList().stream()
+            .anyMatch(w -> w.getMessage().contains("read from a field initializer")),
+            result.getGui().getWarningList().toString());
+    }
+
     @Test
     public void classes1() throws IOException {
         testAssertOkFile(new File(TEST_DIR + "Classes_1.wurst"), true);