-
Notifications
You must be signed in to change notification settings - Fork 71
Update scala-compiler, scala-library, ... to 2.13.18 #4104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @xerial-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request aims to keep the project's Scala dependencies current by upgrading to Scala 2.13.18. This ensures the project benefits from the latest bug fixes, performance improvements, and features available in the new patch release, maintaining compatibility and stability. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with π and π on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the Scala 2.13 version from 2.13.17 to 2.13.18. The changes are correct, and this update is a recommended bugfix release. I've added a couple of suggestions to improve the maintainability of your build configuration by centralizing version definitions. While the PR is good to merge, considering these suggestions will make future dependency updates easier.
|
|
||
| val SCALA_2_12 = "2.12.20" | ||
| val SCALA_2_13 = "2.13.17" | ||
| val SCALA_2_13 = "2.13.18" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Scala 2.13 version SCALA_2_13 is also defined in airspec/build.sbt. This duplication can lead to inconsistencies and makes updates more error-prone, as this PR demonstrates by requiring changes in multiple files. To improve maintainability, consider centralizing version definitions. A common practice in sbt projects is to define versions in a project/Versions.scala object, or a properties file at the root of the repository that can be read by all separate build definitions.
|
|
||
| val AIRFRAME_VERSION = "2025.1.21" | ||
| ThisBuild / scalaVersion := "2.13.17" | ||
| ThisBuild / scalaVersion := "2.13.18" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Scala version is hardcoded here. For better maintainability and readability, it's recommended to define it as a val at the top of the file, similar to AIRFRAME_VERSION. This makes it easier to manage and update versions. For example:
val scalaVersion213 = "2.13.18"
ThisBuild / scalaVersion := scalaVersion213
About this PR
π¦ Updates
from
2.13.17to2.13.18π GitHub Release Notes - Version Diff
Usage
β Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a
.scala-steward.conffile.Have a fantastic day writing Scala!
β Adjust future updates
Add this to your
.scala-steward.conffile to ignore future updates of this dependency:Or, add this to slow down future updates of this dependency: