-
Notifications
You must be signed in to change notification settings - Fork 69
Update postgresql to 42.7.9 #4148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @xerial-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on a routine maintenance update, specifically upgrading the PostgreSQL JDBC driver to its latest patch version. This ensures the project benefits from the most recent bug fixes and minor enhancements provided by the PostgreSQL community, contributing to overall stability and security without introducing significant breaking changes. Highlights
π§ New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with π and π on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the org.postgresql:postgresql dependency to version 42.7.9. This is a recommended update as it includes a security fix for a SQL injection vulnerability (CVE-2024-35102). The change in build.sbt is correct. I've added one suggestion to improve maintainability by extracting the version string into a variable, which is consistent with the project's style for managing other dependencies.
| "org.xerial" % "sqlite-jdbc" % SQLITE_JDBC_VERSION, | ||
| "org.duckdb" % "duckdb_jdbc" % "1.4.3.0", | ||
| "org.postgresql" % "postgresql" % "42.7.8", | ||
| "org.postgresql" % "postgresql" % "42.7.9", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For consistency with other dependencies in this file (like SQLITE_JDBC_VERSION), consider extracting this version string into a val at the top of build.sbt. This improves maintainability by centralizing version numbers.
For example, you could add this at the top of the file:
val POSTGRESQL_VERSION = "42.7.9"And then use it here:
"org.postgresql" % "postgresql" % POSTGRESQL_VERSIONThis practice could also be applied to other hardcoded versions in this block, such as for duckdb_jdbc and HikariCP.
About this PR
π¦ Updates org.postgresql:postgresql from
42.7.8to42.7.9π Changelog
Usage
β Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a
.scala-steward.conffile.Have a fantastic day writing Scala!
β Adjust future updates
Add this to your
.scala-steward.conffile to ignore future updates of this dependency:Or, add this to slow down future updates of this dependency: