Merge pull request #21 from wwarne/bump_version

Fix some typing warnings

Redis package already has some stubs 
I mistakenly had used types-redis package which is only for redis-py 4.6

Author: wwarne

pyproject.toml

@@ -1,6 +1,6 @@
 [project]
 name = "dogpile_breaker"
-version = "0.13.0"
+version = "0.14.0"
 description = "Cache for Asyncio Applications with Anti-Dogpile Effect"
 readme = "README.md"
 authors = [
@@ -32,7 +32,6 @@ dev = [
     "pytest>=8.3.4",
     "pytest-asyncio>=0.25.3",
     "ruff>=0.8.3",
-    "types-redis>=4.6.0.20241004",
 ]
 
 [tool.ruff]

src/dogpile_breaker/backends/redis_backend.py

@@ -66,8 +66,8 @@ async def aclose(self) -> None:
         # https://github.com/redis/redis-py/issues/2995#issuecomment-1764876240
         # by default closing redis won't close the connection pool and it could lead
         # to problems. So we need to make sure we close the connections.
-        await self.redis.aclose()  # type:ignore[attr-defined]
-        await self.pool.aclose()  # type:ignore[attr-defined]
+        await self.redis.aclose()
+        await self.pool.aclose()
 
     async def get_serialized(self, key: str) -> bytes | None:
         return cast("bytes | None", await self.redis.get(key))
@@ -122,7 +122,7 @@ def __init__(
             "retry_on_error", [RedisConnectionError, RedisTimeoutError, ConnectionRefusedError]
         )
         self.master_name = master_name
-        self.sentinel = Sentinel(
+        self.sentinel = Sentinel(  # type:ignore[no-untyped-call]
             sentinels=sentinels,
             retry=retry,
             retry_on_error=retry_on_error,
@@ -143,4 +143,4 @@ async def initialize(self) -> None:
     async def aclose(self) -> None:
         # then using sentinel.master_for
         # The Redis object "owns" the pool so it closes after closing Redis instance
-        await self.redis.aclose()  # type:ignore[attr-defined]
+        await self.redis.aclose()

src/dogpile_breaker/backends/redis_client.py

@@ -22,7 +22,7 @@
 Unused: TypeAlias = object
 
 
-class AsyncRedisClient(Redis):  # type:ignore[type-arg]
+class AsyncRedisClient(Redis):
     # Note - mypy throws error - Call to untyped function "execute_command" in typed context
     @override
     async def execute_command(self, *args: Any, **options: Any) -> Any:
@@ -37,7 +37,7 @@ async def execute_command(self, *args: Any, **options: Any) -> Any:
             raise CacheBackendInteractionError from e
 
 
-class SentinelBlockingPool(SentinelConnectionPool):  # type:ignore[type-arg]
+class SentinelBlockingPool(SentinelConnectionPool):
     """
     It performs the same function as the default
     `redis.asyncio.SentinelConnectionPool` implementation, in that,
@@ -58,22 +58,22 @@ class SentinelBlockingPool(SentinelConnectionPool):  # type:ignore[type-arg]
 
     def __init__(self, service_name: str, sentinel_manager: Sentinel, **kwargs: Any) -> None:
         self.timeout = kwargs.pop("timeout", 20)
-        super().__init__(service_name, sentinel_manager, **kwargs)
+        super().__init__(service_name, sentinel_manager, **kwargs)  # type:ignore[no-untyped-call]
         self._condition = asyncio.Condition()
 
-    async def get_connection(self, command_name: Unused, *keys: Unused, **options: Unused) -> _ConnectionT:  # noqa: ARG002
+    async def get_connection(self, command_name: Any = ..., *keys: Any, **options: Any) -> _ConnectionT:  # noqa: ARG002
         """Gets a connection from the pool, blocking until one is available"""
         try:
             async with self._condition:  # noqa: SIM117
                 async with async_timeout(self.timeout):
-                    await self._condition.wait_for(self.can_get_connection)  # type:ignore[attr-defined]
-                    connection = super().get_available_connection()  # type:ignore[misc]
+                    await self._condition.wait_for(self.can_get_connection)
+                    connection = super().get_available_connection()  # type:ignore[no-untyped-call]
         except asyncio.TimeoutError as err:
             raise ConnectionError("No connection available.") from err  # noqa: EM101, TRY003
 
         # We now perform the connection check outside of the lock.
         try:
-            await self.ensure_connection(connection)  # type:ignore[attr-defined]
+            await self.ensure_connection(connection)
         except BaseException:
             await self.release(connection)
             raise