Skip to content

Commit 99a8e06

Browse files
committed
Fix error in unit test
test_optimum_pipe_predict_and_predict_proba_and_transform() was throwing an error every time PCA was selected as HP. The scaled data had to be passed to the PCA, which wasn't done before.
1 parent 9913557 commit 99a8e06

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

test/base_tests/test_hyperpipe.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -753,8 +753,8 @@ def test_optimum_pipe_predict_and_predict_proba_and_transform(self):
753753
('RandomForestClassifier', RandomForestClassifier(random_state=42))]
754754
else:
755755
sk_elements = [('StandardScaler', StandardScaler()),
756-
('PCA', PCA(random_state=42)),
757-
('RandomForestClassifier', RandomForestClassifier(random_state=42))]
756+
('PCA', PCA(random_state=42)),
757+
('RandomForestClassifier', RandomForestClassifier(random_state=42))]
758758
self.sklearn_pipe = SKLPipeline(sk_elements)
759759
self.sklearn_pipe.set_params(**best_config_copy)
760760
self.sklearn_pipe.fit(self.__X, self.__y)
@@ -765,7 +765,7 @@ def test_optimum_pipe_predict_and_predict_proba_and_transform(self):
765765
# fake transform on sklearn pipe
766766
step1 = self.sklearn_pipe.named_steps["StandardScaler"].transform(self.__X)
767767
if "PCA" in self.sklearn_pipe.named_steps:
768-
step2 = self.sklearn_pipe.named_steps["PCA"].transform(self.__X)
768+
step2 = self.sklearn_pipe.named_steps["PCA"].transform(step1)
769769
else:
770770
step2 = step1
771771
self.assertTrue(np.allclose(step2, self.hyperpipe.transform(self.__X)))

0 commit comments

Comments
 (0)