Skip to content

Commit 091474e

Browse files
committed
fix: Stricter RuleTester validations
1 parent d493a0b commit 091474e

35 files changed

+20
-74
lines changed

lib/rules/no-unexpected-string-bool.js

+4
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,10 @@ module.exports = {
2424
if (node.value === "true" || node.value === "false") {
2525
context.report({
2626
node,
27+
data: {
28+
true: "true",
29+
false: "false",
30+
},
2731
messageId: node.value === "true" ? "trueString" : "falseString",
2832
});
2933
}

lib/rules/omit-bool-attributes.js

+5-1
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,11 @@ module.exports = {
2424
context.report({
2525
node,
2626
messageId: "omitWarn",
27-
data: { attrKey: node.key },
27+
data: {
28+
attrKey: node.key,
29+
true: "true",
30+
false: "false",
31+
},
2832
});
2933
}
3034
}

lib/rules/report-interpolation-error.js

+3-3
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ module.exports = {
2424
}
2525
try {
2626
espreeParser = require("espree");
27-
// eslint-disable-next-line no-unused-vars
27+
// eslint-disable-next-line no-unused-vars
2828
} catch (_) {
2929
// ...
3030
}
@@ -38,13 +38,13 @@ module.exports = {
3838
espreeParser.parse(`({${node.value}})`, {
3939
ecmaVersion: espreeParser.latestEcmaVersion,
4040
});
41-
// eslint-disable-next-line no-unused-vars
41+
// eslint-disable-next-line no-unused-vars
4242
} catch (_) {
4343
try {
4444
espreeParser.parse(`(${node.value})`, {
4545
ecmaVersion: espreeParser.latestEcmaVersion,
4646
});
47-
// eslint-disable-next-line no-unused-vars
47+
// eslint-disable-next-line no-unused-vars
4848
} catch (_) {
4949
context.report({
5050
node,

tests/rule-tester-compat.js

+8-8
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
const eslint = require("eslint");
22
const semver = require("semver");
33

4-
const ruleTester = semver.gte(eslint.Linter.version, '9.0.0-0') ?
5-
new eslint.RuleTester({
6-
languageOptions: {
7-
parser: require("@wxml/parser"),
8-
},
9-
}) :
10-
new eslint.RuleTester({ parser: require.resolve("@wxml/parser") });
4+
const ruleTester = semver.gte(eslint.Linter.version, "9.0.0-0")
5+
? new eslint.RuleTester({
6+
languageOptions: {
7+
parser: require("@wxml/parser"),
8+
},
9+
})
10+
: new eslint.RuleTester({ parser: require.resolve("@wxml/parser") });
1111

12-
module.exports.RuleTester = ruleTester;
12+
module.exports.RuleTester = ruleTester;

tests/rules/colon-style-event-binding.js

-2
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
const tester = require("../rule-tester-compat").RuleTester;
22
const rule = require("../../lib/rules/colon-style-event-binding");
33

4-
5-
64
tester.run("colon-style-event-binding", rule, {
75
valid: [
86
{

tests/rules/empty-tag-self-closing.js

-2
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
const tester = require("../rule-tester-compat").RuleTester;
22
const rule = require("../../lib/rules/empty-tag-self-closing");
33

4-
5-
64
tester.run("empty-tag-self-closing", rule, {
75
valid: [
86
{

tests/rules/event-binding-style.js

-2
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
const tester = require("../rule-tester-compat").RuleTester;
22
const rule = require("../../lib/rules/event-binding-style");
33

4-
5-
64
tester.run("event-binding-style", rule, {
75
valid: [
86
{

tests/rules/forbid-attributes.js

-2
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
const tester = require("../rule-tester-compat").RuleTester;
22
const rule = require("../../lib/rules/forbid-attributes");
33

4-
5-
64
tester.run("forbid-attributes", rule, {
75
valid: [
86
{

tests/rules/forbid-tags.js

-2
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
const tester = require("../rule-tester-compat").RuleTester;
22
const rule = require("../../lib/rules/forbid-tags");
33

4-
5-
64
tester.run("forbid-tags", rule, {
75
valid: [
86
{

tests/rules/max-depth.js

-2
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
const tester = require("../rule-tester-compat").RuleTester;
22
const rule = require("../../lib/rules/max-depth");
33

4-
5-
64
tester.run("max-depth", rule, {
75
valid: [
86
{

tests/rules/max-len.js

-2
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
const tester = require("../rule-tester-compat").RuleTester;
22
const rule = require("../../lib/rules/max-len");
33

4-
5-
64
tester.run("max-len", rule, {
75
valid: [
86
{

tests/rules/max-lines.js

-2
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,6 @@ const path = require("path");
33
const tester = require("../rule-tester-compat").RuleTester;
44
const rule = require("../../lib/rules/max-lines");
55

6-
7-
86
function readFixureFiles(filename) {
97
if (filename) {
108
return fs.readFileSync(

tests/rules/no-const-and-let-in-wxs.js

-2
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
const tester = require("../rule-tester-compat").RuleTester;
22
const rule = require("../../lib/rules/no-const-and-let-in-wxs");
33

4-
5-
64
tester.run("no-const-and-let-in-wxs", rule, {
75
valid: [
86
{

tests/rules/no-dot-this-in-wx-key.js

-2
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
const tester = require("../rule-tester-compat").RuleTester;
22
const rule = require("../../lib/rules/no-dot-this-in-wx-key");
33

4-
5-
64
tester.run("no-dot-this-in-wx-key", rule, {
75
valid: [
86
{

tests/rules/no-duplicate-attributes.js

-2
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
const tester = require("../rule-tester-compat").RuleTester;
22
const rule = require("../../lib/rules/no-duplicate-attributes");
33

4-
5-
64
tester.run("no-duplicate-attributes", rule, {
75
valid: [
86
{

tests/rules/no-dynamic-wx-key.js

-2
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
const tester = require("../rule-tester-compat").RuleTester;
22
const rule = require("../../lib/rules/no-dynamic-wx-key");
33

4-
5-
64
tester.run("no-dynamic-wx-key", rule, {
75
valid: [
86
{

tests/rules/no-inconsistent-tagname.js

-2
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
const tester = require("../rule-tester-compat").RuleTester;
22
const rule = require("../../lib/rules/no-inconsistent-tagname");
33

4-
5-
64
tester.run("no-inconsistent-tagname", rule, {
75
valid: [
86
{

tests/rules/no-index-in-wx-key.js

-2
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
const tester = require("../rule-tester-compat").RuleTester;
22
const rule = require("../../lib/rules/no-index-in-wx-key");
33

4-
5-
64
tester.run("no-index-in-wx-key", rule, {
75
valid: [
86
{

tests/rules/no-inline-wxs.js

-2
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
const tester = require("../rule-tester-compat").RuleTester;
22
const rule = require("../../lib/rules/no-inline-wxs");
33

4-
5-
64
tester.run("no-inline-wxs", rule, {
75
valid: [
86
{

tests/rules/no-unexpected-string-bool.js

-2
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
const tester = require("../rule-tester-compat").RuleTester;
22
const rule = require("../../lib/rules/no-unexpected-string-bool");
33

4-
5-
64
tester.run("no-unexpected-string-bool", rule, {
75
valid: [
86
{

tests/rules/no-unnecessary-block.js

-2
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
const tester = require("../rule-tester-compat").RuleTester;
22
const rule = require("../../lib/rules/no-unnecessary-block");
33

4-
5-
64
tester.run("no-unnecessary-block", rule, {
75
valid: [
86
{

tests/rules/no-vue-directive.js

-2
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
const tester = require("../rule-tester-compat").RuleTester;
22
const rule = require("../../lib/rules/no-vue-directive");
33

4-
5-
64
tester.run("no-vue-directive", rule, {
75
valid: [
86
{

tests/rules/no-wx-for-with-wx-else.js

-2
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
const tester = require("../rule-tester-compat").RuleTester;
22
const rule = require("../../lib/rules/no-wx-for-with-wx-else");
33

4-
5-
64
tester.run("no-wx-for-with-wx-else", rule, {
75
valid: [
86
{

tests/rules/no-wx-for-with-wx-if.js

-2
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
const tester = require("../rule-tester-compat").RuleTester;
22
const rule = require("../../lib/rules/no-wx-for-with-wx-if");
33

4-
5-
64
tester.run("no-wx-for-with-wx-if", rule, {
75
valid: [
86
{

tests/rules/no-wx-if-string.js

-2
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
const tester = require("../rule-tester-compat").RuleTester;
22
const rule = require("../../lib/rules/no-wx-if-string");
33

4-
5-
64
tester.run("no-wx-if-string", rule, {
75
valid: [
86
{

tests/rules/omit-bool-attributes.js

-2
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
const tester = require("../rule-tester-compat").RuleTester;
22
const rule = require("../../lib/rules/omit-bool-attributes");
33

4-
5-
64
tester.run("omit-bool-attributes", rule, {
75
valid: [
86
{

tests/rules/quotes.js

-2
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
const tester = require("../rule-tester-compat").RuleTester;
22
const rule = require("../../lib/rules/quotes");
33

4-
5-
64
tester.run("quotes", rule, {
75
valid: [
86
{

tests/rules/report-interpolation-error.js

-2
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
const tester = require("../rule-tester-compat").RuleTester;
22
const rule = require("../../lib/rules/report-interpolation-error");
33

4-
5-
64
tester.run("report-interpolation-error", rule, {
75
valid: [
86
{

tests/rules/report-wxml-syntax-error.js

-2
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
const tester = require("../rule-tester-compat").RuleTester;
22
const rule = require("../../lib/rules/report-wxml-syntax-error");
33

4-
5-
64
tester.run("report-wxml-syntax-error", rule, {
75
valid: [
86
{

tests/rules/report-wxs-syntax-error.js

-2
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
const tester = require("../rule-tester-compat").RuleTester;
22
const rule = require("../../lib/rules/report-wxs-syntax-error");
33

4-
5-
64
tester.run("report-wxs-syntax-error", rule, {
75
valid: [
86
{

tests/rules/required-attributes.js

-2
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
const tester = require("../rule-tester-compat").RuleTester;
22
const rule = require("../../lib/rules/required-attributes");
33

4-
5-
64
tester.run("required-attributes", rule, {
75
valid: [
86
{

tests/rules/required-root-tag.js

-2
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
const tester = require("../rule-tester-compat").RuleTester;
22
const rule = require("../../lib/rules/required-root-tag");
33

4-
5-
64
tester.run("required-root-tag", rule, {
75
valid: [
86
{

tests/rules/required-tags.js

-2
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
const tester = require("../rule-tester-compat").RuleTester;
22
const rule = require("../../lib/rules/required-tags");
33

4-
5-
64
tester.run("required-tags", rule, {
75
valid: [
86
{

tests/rules/wx-key.js

-2
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
const tester = require("../rule-tester-compat").RuleTester;
22
const rule = require("../../lib/rules/wx-key");
33

4-
5-
64
tester.run("wx-key", rule, {
75
valid: [
86
{

tests/rules/wxs-module-prop.js

-2
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
const tester = require("../rule-tester-compat").RuleTester;
22
const rule = require("../../lib/rules/wxs-module-prop");
33

4-
5-
64
tester.run("wxs-module-prop", rule, {
75
valid: [
86
{

0 commit comments

Comments
 (0)