ci: eslint v9 test (#64)

iChenLei · web-flow · commit 95a5c81c8882 · 2024-04-19T17:25:57.000+08:00
* ci: eslint v9 test

* fix: eslint9 compat

* fix: raw eslint config

* chore: fix

* fix: add eslint9 compatiable rule tester

* fix: add semver

* fix: Stricter RuleTester validations

* fix: error message

* fix: false val with brackets

* fix: eslint9 strict ruletester
diff --git a/.eslintignore b/.eslintignore
@@ -1,2 +1,3 @@
 website/
 tools/
+eslint.config.mjs
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -2,5 +2,8 @@ module.exports = {
   extends: ['eslint:recommended', 'plugin:node/recommended', 'plugin:eslint-plugin/recommended'],
   env: {
    es6: true
+  },
+  rules: {
+    "node/no-extraneous-require": "off"
   }
 }
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -35,6 +35,20 @@ jobs:
     - run: npm run lint
     - run: npm run test
 
+  eslint9_test:
+    name: Test eslint-plugin-wxml with eslint9
+    runs-on: ubuntu-latest
+
+    steps:
+    - uses: actions/checkout@v3
+    - uses: actions/setup-node@v3
+      with: {node-version: '${{ env.NODE_VERSION }}'}
+    - run: npm install
+    - run: npm install eslint@9
+    - run: npm install semver
+    - run: npm run lint
+    - run: npm run test
+
   eslint8_test:
     name: Test eslint-plugin-wxml with eslint8
     runs-on: ubuntu-latest
@@ -45,6 +59,7 @@ jobs:
       with: {node-version: '${{ env.NODE_VERSION }}'}
     - run: npm install
     - run: npm install eslint@8
+    - run: npm install semver
     - run: npm run lint
     - run: npm run test
 
diff --git a/eslint.config.mjs b/eslint.config.mjs
@@ -0,0 +1,17 @@
+import js from "@eslint/js";
+
+export default [
+    {
+        ...js.configs.recommended,
+        files: ["lib/**/*.js"],
+        ignores: ["website/**", "tools/**"]
+    },
+    {
+        languageOptions: {
+            globals: {
+                module: "readonly",
+                require: "readonly",
+            }
+        }
+    }
+];
diff --git a/lib/rules/no-unexpected-string-bool.js b/lib/rules/no-unexpected-string-bool.js
@@ -24,6 +24,10 @@ module.exports = {
           if (node.value === "true" || node.value === "false") {
             context.report({
               node,
+              data: {
+                true: "{{true}}",
+                false: "{{false}}",
+              },
               messageId: node.value === "true" ? "trueString" : "falseString",
             });
           }
diff --git a/lib/rules/omit-bool-attributes.js b/lib/rules/omit-bool-attributes.js
@@ -24,7 +24,11 @@ module.exports = {
             context.report({
               node,
               messageId: "omitWarn",
-              data: { attrKey: node.key },
+              data: {
+                attrKey: node.key,
+                true: "{{true}}",
+                false: "{{false}}",
+              },
             });
           }
         }
diff --git a/lib/rules/report-interpolation-error.js b/lib/rules/report-interpolation-error.js
@@ -23,8 +23,8 @@ module.exports = {
           return;
         }
         try {
-          // eslint-disable-next-line node/no-extraneous-require
           espreeParser = require("espree");
+          // eslint-disable-next-line no-unused-vars
         } catch (_) {
           // ...
         }
@@ -38,11 +38,13 @@ module.exports = {
               espreeParser.parse(`({${node.value}})`, {
                 ecmaVersion: espreeParser.latestEcmaVersion,
               });
+              // eslint-disable-next-line no-unused-vars
             } catch (_) {
               try {
                 espreeParser.parse(`(${node.value})`, {
                   ecmaVersion: espreeParser.latestEcmaVersion,
                 });
+                // eslint-disable-next-line no-unused-vars
               } catch (_) {
                 context.report({
                   node,
diff --git a/tests/rule-tester-compat.js b/tests/rule-tester-compat.js
@@ -0,0 +1,12 @@
+const eslint = require("eslint");
+const semver = require("semver");
+
+const ruleTester = semver.gte(eslint.Linter.version, "9.0.0-0")
+  ? new eslint.RuleTester({
+      languageOptions: {
+        parser: require("@wxml/parser"),
+      },
+    })
+  : new eslint.RuleTester({ parser: require.resolve("@wxml/parser") });
+
+module.exports.RuleTester = ruleTester;
diff --git a/tests/rules/colon-style-event-binding.js b/tests/rules/colon-style-event-binding.js
@@ -1,10 +1,6 @@
-const RuleTester = require("eslint").RuleTester;
+const tester = require("../rule-tester-compat").RuleTester;
 const rule = require("../../lib/rules/colon-style-event-binding");
 
-const tester = new RuleTester({
-  parser: require.resolve("@wxml/parser"),
-});
-
 tester.run("colon-style-event-binding", rule, {
   valid: [
     {
diff --git a/tests/rules/empty-tag-self-closing.js b/tests/rules/empty-tag-self-closing.js
@@ -1,10 +1,6 @@
-const RuleTester = require("eslint").RuleTester;
+const tester = require("../rule-tester-compat").RuleTester;
 const rule = require("../../lib/rules/empty-tag-self-closing");
 
-const tester = new RuleTester({
-  parser: require.resolve("@wxml/parser"),
-});
-
 tester.run("empty-tag-self-closing", rule, {
   valid: [
     {
diff --git a/tests/rules/event-binding-style.js b/tests/rules/event-binding-style.js
@@ -1,10 +1,6 @@
-const RuleTester = require("eslint").RuleTester;
+const tester = require("../rule-tester-compat").RuleTester;
 const rule = require("../../lib/rules/event-binding-style");
 
-const tester = new RuleTester({
-  parser: require.resolve("@wxml/parser"),
-});
-
 tester.run("event-binding-style", rule, {
   valid: [
     {
diff --git a/tests/rules/forbid-attributes.js b/tests/rules/forbid-attributes.js
@@ -1,10 +1,6 @@
-const RuleTester = require("eslint").RuleTester;
+const tester = require("../rule-tester-compat").RuleTester;
 const rule = require("../../lib/rules/forbid-attributes");
 
-const tester = new RuleTester({
-  parser: require.resolve("@wxml/parser"),
-});
-
 tester.run("forbid-attributes", rule, {
   valid: [
     {
diff --git a/tests/rules/forbid-tags.js b/tests/rules/forbid-tags.js
@@ -1,10 +1,6 @@
-const RuleTester = require("eslint").RuleTester;
+const tester = require("../rule-tester-compat").RuleTester;
 const rule = require("../../lib/rules/forbid-tags");
 
-const tester = new RuleTester({
-  parser: require.resolve("@wxml/parser"),
-});
-
 tester.run("forbid-tags", rule, {
   valid: [
     {
diff --git a/tests/rules/max-depth.js b/tests/rules/max-depth.js
@@ -1,10 +1,6 @@
-const RuleTester = require("eslint").RuleTester;
+const tester = require("../rule-tester-compat").RuleTester;
 const rule = require("../../lib/rules/max-depth");
 
-const tester = new RuleTester({
-  parser: require.resolve("@wxml/parser"),
-});
-
 tester.run("max-depth", rule, {
   valid: [
     {
diff --git a/tests/rules/max-len.js b/tests/rules/max-len.js
@@ -1,10 +1,6 @@
-const RuleTester = require("eslint").RuleTester;
+const tester = require("../rule-tester-compat").RuleTester;
 const rule = require("../../lib/rules/max-len");
 
-const tester = new RuleTester({
-  parser: require.resolve("@wxml/parser"),
-});
-
 tester.run("max-len", rule, {
   valid: [
     {
diff --git a/tests/rules/max-lines.js b/tests/rules/max-lines.js
@@ -1,12 +1,8 @@
 const fs = require("fs");
 const path = require("path");
-const RuleTester = require("eslint").RuleTester;
+const tester = require("../rule-tester-compat").RuleTester;
 const rule = require("../../lib/rules/max-lines");
 
-const tester = new RuleTester({
-  parser: require.resolve("@wxml/parser"),
-});
-
 function readFixureFiles(filename) {
   if (filename) {
     return fs.readFileSync(
diff --git a/tests/rules/no-const-and-let-in-wxs.js b/tests/rules/no-const-and-let-in-wxs.js
@@ -1,10 +1,6 @@
-const RuleTester = require("eslint").RuleTester;
+const tester = require("../rule-tester-compat").RuleTester;
 const rule = require("../../lib/rules/no-const-and-let-in-wxs");
 
-const tester = new RuleTester({
-  parser: require.resolve("@wxml/parser"),
-});
-
 tester.run("no-const-and-let-in-wxs", rule, {
   valid: [
     {
diff --git a/tests/rules/no-dot-this-in-wx-key.js b/tests/rules/no-dot-this-in-wx-key.js
@@ -1,10 +1,6 @@
-const RuleTester = require("eslint").RuleTester;
+const tester = require("../rule-tester-compat").RuleTester;
 const rule = require("../../lib/rules/no-dot-this-in-wx-key");
 
-const tester = new RuleTester({
-  parser: require.resolve("@wxml/parser"),
-});
-
 tester.run("no-dot-this-in-wx-key", rule, {
   valid: [
     {
diff --git a/tests/rules/no-duplicate-attributes.js b/tests/rules/no-duplicate-attributes.js
@@ -1,10 +1,6 @@
-const RuleTester = require("eslint").RuleTester;
+const tester = require("../rule-tester-compat").RuleTester;
 const rule = require("../../lib/rules/no-duplicate-attributes");
 
-const tester = new RuleTester({
-  parser: require.resolve("@wxml/parser"),
-});
-
 tester.run("no-duplicate-attributes", rule, {
   valid: [
     {
diff --git a/tests/rules/no-dynamic-wx-key.js b/tests/rules/no-dynamic-wx-key.js
@@ -1,10 +1,6 @@
-const RuleTester = require("eslint").RuleTester;
+const tester = require("../rule-tester-compat").RuleTester;
 const rule = require("../../lib/rules/no-dynamic-wx-key");
 
-const tester = new RuleTester({
-  parser: require.resolve("@wxml/parser"),
-});
-
 tester.run("no-dynamic-wx-key", rule, {
   valid: [
     {
diff --git a/tests/rules/no-inconsistent-tagname.js b/tests/rules/no-inconsistent-tagname.js
@@ -1,10 +1,6 @@
-const RuleTester = require("eslint").RuleTester;
+const tester = require("../rule-tester-compat").RuleTester;
 const rule = require("../../lib/rules/no-inconsistent-tagname");
 
-const tester = new RuleTester({
-  parser: require.resolve("@wxml/parser"),
-});
-
 tester.run("no-inconsistent-tagname", rule, {
   valid: [
     {
diff --git a/tests/rules/no-index-in-wx-key.js b/tests/rules/no-index-in-wx-key.js
@@ -1,10 +1,6 @@
-const RuleTester = require("eslint").RuleTester;
+const tester = require("../rule-tester-compat").RuleTester;
 const rule = require("../../lib/rules/no-index-in-wx-key");
 
-const tester = new RuleTester({
-  parser: require.resolve("@wxml/parser"),
-});
-
 tester.run("no-index-in-wx-key", rule, {
   valid: [
     {
diff --git a/tests/rules/no-inline-wxs.js b/tests/rules/no-inline-wxs.js
@@ -1,10 +1,6 @@
-const RuleTester = require("eslint").RuleTester;
+const tester = require("../rule-tester-compat").RuleTester;
 const rule = require("../../lib/rules/no-inline-wxs");
 
-const tester = new RuleTester({
-  parser: require.resolve("@wxml/parser"),
-});
-
 tester.run("no-inline-wxs", rule, {
   valid: [
     {
diff --git a/tests/rules/no-unexpected-string-bool.js b/tests/rules/no-unexpected-string-bool.js
@@ -1,10 +1,6 @@
-const RuleTester = require("eslint").RuleTester;
+const tester = require("../rule-tester-compat").RuleTester;
 const rule = require("../../lib/rules/no-unexpected-string-bool");
 
-const tester = new RuleTester({
-  parser: require.resolve("@wxml/parser"),
-});
-
 tester.run("no-unexpected-string-bool", rule, {
   valid: [
     {
@@ -24,17 +20,41 @@ tester.run("no-unexpected-string-bool", rule, {
     {
       filename: "test.wxml",
       code: `<popup wx:if="true" />`,
-      errors: [{ messageId: "trueString" }],
+      errors: [
+        {
+          messageId: "trueString",
+          data: {
+            true: "{{true}}",
+            false: "{{false}}",
+          },
+        },
+      ],
     },
     {
       filename: "test.wxml",
       code: `<popup wx:if="false" />`,
-      errors: [{ messageId: "falseString" }],
+      errors: [
+        {
+          messageId: "falseString",
+          data: {
+            true: "{{true}}",
+            false: "{{false}}",
+          },
+        },
+      ],
     },
     {
       filename: "test.wxml",
       code: `<dialog showAnime="false" />`,
-      errors: [{ messageId: "falseString" }],
+      errors: [
+        {
+          messageId: "falseString",
+          data: {
+            true: "{{true}}",
+            false: "{{false}}",
+          },
+        },
+      ],
     },
   ],
 });
diff --git a/tests/rules/no-unnecessary-block.js b/tests/rules/no-unnecessary-block.js
@@ -1,10 +1,6 @@
-const RuleTester = require("eslint").RuleTester;
+const tester = require("../rule-tester-compat").RuleTester;
 const rule = require("../../lib/rules/no-unnecessary-block");
 
-const tester = new RuleTester({
-  parser: require.resolve("@wxml/parser"),
-});
-
 tester.run("no-unnecessary-block", rule, {
   valid: [
     {
diff --git a/tests/rules/no-vue-directive.js b/tests/rules/no-vue-directive.js
@@ -1,10 +1,6 @@
-const RuleTester = require("eslint").RuleTester;
+const tester = require("../rule-tester-compat").RuleTester;
 const rule = require("../../lib/rules/no-vue-directive");
 
-const tester = new RuleTester({
-  parser: require.resolve("@wxml/parser"),
-});
-
 tester.run("no-vue-directive", rule, {
   valid: [
     {
diff --git a/tests/rules/no-wx-for-with-wx-else.js b/tests/rules/no-wx-for-with-wx-else.js
@@ -1,10 +1,6 @@
-const RuleTester = require("eslint").RuleTester;
+const tester = require("../rule-tester-compat").RuleTester;
 const rule = require("../../lib/rules/no-wx-for-with-wx-else");
 
-const tester = new RuleTester({
-  parser: require.resolve("@wxml/parser"),
-});
-
 tester.run("no-wx-for-with-wx-else", rule, {
   valid: [
     {
diff --git a/tests/rules/no-wx-for-with-wx-if.js b/tests/rules/no-wx-for-with-wx-if.js
diff --git a/tests/rules/no-wx-if-string.js b/tests/rules/no-wx-if-string.js
diff --git a/tests/rules/omit-bool-attributes.js b/tests/rules/omit-bool-attributes.js
diff --git a/tests/rules/quotes.js b/tests/rules/quotes.js
diff --git a/tests/rules/report-interpolation-error.js b/tests/rules/report-interpolation-error.js
diff --git a/tests/rules/report-wxml-syntax-error.js b/tests/rules/report-wxml-syntax-error.js
diff --git a/tests/rules/report-wxs-syntax-error.js b/tests/rules/report-wxs-syntax-error.js
diff --git a/tests/rules/required-attributes.js b/tests/rules/required-attributes.js
diff --git a/tests/rules/required-root-tag.js b/tests/rules/required-root-tag.js
diff --git a/tests/rules/required-tags.js b/tests/rules/required-tags.js
diff --git a/tests/rules/wx-key.js b/tests/rules/wx-key.js
diff --git a/tests/rules/wxs-module-prop.js b/tests/rules/wxs-module-prop.js
diff --git a/tests/rules/wxs-must-be-top-level.js b/tests/rules/wxs-must-be-top-level.js

Original file line number	Diff line number	Diff line change
`@@ -1,2 +1,3 @@`
`1`	`1`	`website/`
`2`	`2`	`tools/`
	`3`	`+eslint.config.mjs`
Original file line number	Diff line number	Diff line change
`@@ -2,5 +2,8 @@ module.exports = {`
`2`	`2`	`extends: ['eslint:recommended', 'plugin:node/recommended', 'plugin:eslint-plugin/recommended'],`
`3`	`3`	`env: {`
`4`	`4`	`es6: true`
	`5`	`+ },`
	`6`	`+ rules: {`
	`7`	`+ "node/no-extraneous-require": "off"`
`5`	`8`	`}`
`6`	`9`	`}`
Original file line number	Diff line number	Diff line change
`@@ -24,7 +24,11 @@ module.exports = {`
`24`	`24`	`context.report({`
`25`	`25`	`node,`
`26`	`26`	`messageId: "omitWarn",`
`27`		`- data: { attrKey: node.key },`
	`27`	`+ data: {`
	`28`	`+ attrKey: node.key,`
	`29`	`+ true: "{{true}}",`
	`30`	`+ false: "{{false}}",`
	`31`	`+ },`
`28`	`32`	`});`
`29`	`33`	`}`
`30`	`34`	`}`