Fix some bad practices and compilation warnings

Author: wysaid

examples/desktop.cmake

@@ -38,6 +38,7 @@ message(STATUS "ccap: GLFW available: ${GLFW_AVAILABLE}")
 
 add_library(common_utils STATIC ${DESKTOP_EXAMPLES_DIR}/utils/helper.cpp)
 target_include_directories(common_utils PRIVATE ${DESKTOP_EXAMPLES_DIR}/utils)
+target_compile_definitions(common_utils PUBLIC _CRT_SECURE_NO_WARNINGS=1)
 target_link_libraries(common_utils PUBLIC ccap)
 
 file(GLOB EXAMPLE_SOURCE ${DESKTOP_EXAMPLES_DIR}/*.cpp ${DESKTOP_EXAMPLES_DIR}/*.c)
@@ -52,7 +53,6 @@ foreach(EXAMPLE ${EXAMPLE_SOURCE})
     endif()
 
     add_executable(${EXAMPLE_NAME} ${EXAMPLE})
-    target_compile_definitions(${EXAMPLE_NAME} PRIVATE _CRT_SECURE_NO_WARNINGS=1)
     target_link_libraries(${EXAMPLE_NAME} PRIVATE common_utils)
 
     if(APPLE)

examples/desktop/2-capture_grab_c.c

@@ -9,12 +9,11 @@
 #include "ccap_utils_c.h"
 #include "utils/helper.h"
 
+#include <ctype.h>
 #include <stdio.h>
 #include <stdlib.h>
 #include <string.h>
 
-#include <ctype.h>
-
 int main(int argc, char** argv) {
     printf("ccap C Interface Capture Grab Example\n");
     printf("Version: %s\n\n", ccap_get_version());
@@ -105,7 +104,7 @@ int main(int argc, char** argv) {
                 // Save frame to directory
                 char outputPath[2048];
                 int result = ccap_dump_frame_to_directory(frame, captureDir, outputPath, sizeof(outputPath));
-                if (result > 0) {
+                if (result >= 0) {
                     printf("VideoFrame saved to: %s\n", outputPath);
                 } else {
                     fprintf(stderr, "Failed to save frame!\n");

examples/desktop/3-capture_callback_c.c

@@ -44,7 +44,7 @@ bool frame_callback(const CcapVideoFrame* frame, void* userData) {
         // Save frame to directory
         char outputPath[2048];
         int result = ccap_dump_frame_to_directory(frame, context->captureDir, outputPath, sizeof(outputPath));
-        if (result > 0) {
+        if (result >= 0) {
             printf("VideoFrame saved to: %s\n", outputPath);
             context->framesSaved++;
         } else {

examples/desktop/utils/helper.cpp

@@ -14,26 +14,33 @@ extern "C" {
 
 // Create directory if not exists
 void createDirectory(const char* path) {
-    try {
-        std::filesystem::create_directories(path);
-    } catch (const std::exception& e) {
-        fprintf(stderr, "Failed to create directory %s: %s\n", path, e.what());
+    std::error_code ec;
+    std::filesystem::create_directories(path, ec);
+    if (ec) {
+        fprintf(stderr, "Failed to create directory %s: %s\n", path, ec.message().c_str());
     }
 }
 
 // Get current working directory (portable)
-int getCurrentWorkingDirectory(char* buffer, int size) {
-    try {
-        auto cwd = std::filesystem::current_path().string();
-        if (cwd.size() >= size) {
-            return -1; // Buffer too small
-        }
-        strcpy(buffer, cwd.c_str());
-        return 0;
-    } catch (const std::exception& e) {
-        fprintf(stderr, "Failed to get current working directory: %s\n", e.what());
+int getCurrentWorkingDirectory(char* buffer, size_t size) {
+    if (!buffer || size == 0) {
+        return -1;
+    }
+
+    std::error_code ec;
+    auto cwd = std::filesystem::current_path(ec);
+    if (ec) {
+        fprintf(stderr, "Failed to get current working directory: %s\n", ec.message().c_str());
         return -1;
     }
+
+    std::string cwd_str = cwd.string();
+    if (cwd_str.size() >= size) {
+        return -1; // Buffer too small
+    }
+    strncpy(buffer, cwd_str.c_str(), size - 1);
+    buffer[size - 1] = '\0';
+    return 0;
 }
 
 int selectCamera(CcapProvider* provider) {

examples/desktop/utils/helper.h

@@ -7,6 +7,8 @@
  */
 #pragma once
 
+#include <stddef.h> // for size_t
+
 #ifdef __cplusplus
 extern "C" {
 #endif
@@ -21,7 +23,7 @@ int selectCamera(CcapProvider* provider);
 void createDirectory(const char* path);
 // Get current working directory (portable)
 // Returns 0 on success, -1 on failure
-int getCurrentWorkingDirectory(char* buffer, int size);
+int getCurrentWorkingDirectory(char* buffer, size_t size);
 
 #ifdef __cplusplus
 } // extern "C"

src/ccap_c.cpp

@@ -103,7 +103,7 @@ bool ccap_provider_find_device_names_list(CcapProvider* provider, CcapDeviceName
 
     // Initialize structure
     memset(deviceList, 0, sizeof(CcapDeviceNamesList));
-    
+
     deviceList->deviceCount = devices.size();
     if (deviceList->deviceCount > CCAP_MAX_DEVICES) {
         deviceList->deviceCount = CCAP_MAX_DEVICES;

src/ccap_imp_linux.h

@@ -99,12 +99,12 @@ class ProviderV4L2 : public ProviderImp {
     bool m_isStreaming = false;
 
     // V4L2 device capabilities
-    struct v4l2_capability m_caps{};
+    struct v4l2_capability m_caps {};
     std::vector<V4L2Format> m_supportedFormats;
     std::vector<DeviceInfo::Resolution> m_supportedResolutions;
 
     // Current format
-    struct v4l2_format m_currentFormat{};
+    struct v4l2_format m_currentFormat {};
 
     // Buffer management
     std::vector<V4L2Buffer> m_buffers;