ci: add video writer test execution to macOS and Windows CI

wysaid · Copilot · wysaid · commit e1e1f0412e5c · 2026-05-24T04:09:46.000+08:00
- Add --writer flag to run_tests.sh for running ccap_video_writer_test
- Add writer test step to macOS CI workflow (Release builds)
- Add writer test step to Windows CI workflow (VS2022/VS2026/MinGW Release)
- On Linux the writer test binary is not built (unsupported platform),
  so the script gracefully skips without error
- Apply code formatting fixes from format_all.sh

Co-authored-by: Copilot &lt;223556219+Copilot@users.noreply.github.com&gt;
diff --git a/.github/workflows/macos-build.yml b/.github/workflows/macos-build.yml
@@ -132,6 +132,9 @@ jobs:
           
           # Run video file playback tests (Release only)
           ./run_tests.sh --video --skip-build
+
+          # Run video writer tests (Release only, macOS/Windows)
+          ./run_tests.sh --writer --skip-build
         fi
       
     - name: Upload artifacts
diff --git a/.github/workflows/windows-build.yml b/.github/workflows/windows-build.yml
@@ -207,6 +207,9 @@ jobs:
           
           # Run video file playback tests (Release only)
           ./run_tests.sh --video --skip-build
+
+          # Run video writer tests (Release only, macOS/Windows)
+          ./run_tests.sh --writer --skip-build
         fi
         
     - name: Upload artifacts
@@ -468,6 +471,9 @@ jobs:
           
           # Run video file playback tests (Release only)
           ./run_tests.sh --video --skip-build
+
+          # Run video writer tests (Release only, macOS/Windows)
+          ./run_tests.sh --writer --skip-build
         fi
         
     - name: Upload artifacts
@@ -631,6 +637,9 @@ jobs:
           
           # Run video file playback tests (Release only)
           ./run_tests.sh --video --skip-build
+
+          # Run video writer tests (Release only, macOS/Windows)
+          ./run_tests.sh --writer --skip-build
         fi
         
     - name: Upload artifacts
diff --git a/examples/desktop/6-record_video_c.c b/examples/desktop/6-record_video_c.c
@@ -131,7 +131,7 @@ int main(int argc, char** argv) {
     writerConfig.width = (uint32_t)realWidth;
     writerConfig.height = (uint32_t)realHeight;
     writerConfig.frameRate = realFps > 0.0 ? realFps : 30.0;
-    writerConfig.bitRate = 0;  // auto bit rate based on resolution and codec (YouTube recommended)
+    writerConfig.bitRate = 0; // auto bit rate based on resolution and codec (YouTube recommended)
 
     CcapVideoWriter* writer = ccap_video_writer_create();
     if (!writer) {
diff --git a/scripts/run_tests.sh b/scripts/run_tests.sh
@@ -18,6 +18,7 @@
 #   ./run_tests.sh --functional       # Run only functional tests (with ASAN)
 #   ./run_tests.sh --performance      # Run only performance tests (without ASAN)
 #   ./run_tests.sh --video            # Run only video file playback tests (Release mode)
+#   ./run_tests.sh --writer           # Run only video writer tests (Release mode, macOS/Windows)
 #   ./run_tests.sh --avx2             # Run only AVX2 performance tests
 #   ./run_tests.sh --shuffle          # Run only tests with names containing 'shuffle' (case-insensitive) in functional tests
 #   ./run_tests.sh --no-sanitize      # Disable ASAN for all tests
@@ -75,6 +76,7 @@ RUN_ALL=false
 RUN_FUNCTIONAL=true
 RUN_PERFORMANCE=true
 RUN_VIDEO=false
+RUN_WRITER=false
 SKIP_BUILD=false
 EXIT_WHEN_FAILED=false
 GTEST_FAIL_FAST_PARAM=""
@@ -91,6 +93,7 @@ while [[ $# -gt 0 ]]; do
         RUN_FUNCTIONAL=true
         RUN_PERFORMANCE=true
         RUN_VIDEO=true
+        RUN_WRITER=true
         shift
         ;;
     -f | --functional)
@@ -116,6 +119,13 @@ while [[ $# -gt 0 ]]; do
         RUN_VIDEO=true
         shift
         ;;
+    --writer)
+        # Video writer tests only (Release mode, macOS/Windows only)
+        RUN_FUNCTIONAL=false
+        RUN_PERFORMANCE=false
+        RUN_WRITER=true
+        shift
+        ;;
     --shuffle)
         # Functional only, and later restrict to tests containing 'shuffle' (case-insensitive)
         RUN_FUNCTIONAL=true
@@ -151,6 +161,7 @@ while [[ $# -gt 0 ]]; do
         echo "  $0 --functional       # Run only functional tests (Debug mode, with ASAN)"
         echo "  $0 --performance      # Run only performance tests (Release mode, without ASAN)"
         echo "  $0 --video            # Run only video file playback tests (Release mode)"
+        echo "  $0 --writer           # Run only video writer tests (Release mode, macOS/Windows)"
         echo "  $0 --avx2             # Run only AVX2 performance tests (Release mode)"
         echo "  $0 --shuffle          # Run only tests whose names contain '*shuffle*' or '*Shuffle*' in functional tests"
         echo "  $0 --skip-build       # Skip build step, run tests only"
@@ -215,6 +226,7 @@ fi
 TEST_RESULT=0
 PERF_RESULT=0
 VIDEO_RESULT=0
+WRITER_RESULT=0
 
 # Determine ASAN usage
 # Functional tests: default enabled, Performance tests: default disabled
@@ -317,13 +329,15 @@ if [ "$RUN_FUNCTIONAL" = true ]; then
 fi
 
 # Build Release version for performance tests or video tests
-if [ "$RUN_PERFORMANCE" = true ] || [ "$RUN_VIDEO" = true ]; then
+if [ "$RUN_PERFORMANCE" = true ] || [ "$RUN_VIDEO" = true ] || [ "$RUN_WRITER" = true ]; then
     echo ""
     echo -e "${PURPLE}===============================================${NC}"
     if [ "$SKIP_BUILD" = true ]; then
         echo -e "${BLUE}Skipping build, using existing Release binaries${NC}"
     else
-        if [ "$RUN_VIDEO" = true ]; then
+        if [ "$RUN_WRITER" = true ] && [ "$RUN_VIDEO" != true ] && [ "$RUN_PERFORMANCE" != true ]; then
+            echo -e "${BLUE}Building Release version (for video writer tests)${NC}"
+        elif [ "$RUN_VIDEO" = true ]; then
             echo -e "${BLUE}Building Release version (for video file playback tests)${NC}"
         else
             echo -e "${BLUE}Building Release version (for performance tests)${NC}"
@@ -365,6 +379,9 @@ if [ "$RUN_PERFORMANCE" = true ] || [ "$RUN_VIDEO" = true ]; then
             if [ "$RUN_VIDEO" = true ]; then
                 cmake --build . --config Release --target ccap_file_playback_test --parallel $(detectCores)
             fi
+            if [ "$RUN_WRITER" = true ]; then
+                cmake --build . --config Release --target ccap_video_writer_test --parallel $(detectCores)
+            fi
             cd ..
         else
             # Linux/Mac: use separate Release directory
@@ -386,6 +403,9 @@ if [ "$RUN_PERFORMANCE" = true ] || [ "$RUN_VIDEO" = true ]; then
             if [ "$RUN_VIDEO" = true ]; then
                 cmake --build . --config Release --target ccap_file_playback_test --parallel $(detectCores)
             fi
+            if [ "$RUN_WRITER" = true ]; then
+                cmake --build . --config Release --target ccap_video_writer_test --parallel $(detectCores)
+            fi
             cd ../..
         fi
     fi
@@ -564,6 +584,45 @@ if [ "$RUN_VIDEO" = true ]; then
     fi
 fi
 
+# Run video writer tests in Release mode (macOS/Windows only)
+WRITER_RESULT=0
+if [ "$RUN_WRITER" = true ]; then
+    echo ""
+    echo "==============================================="
+    echo -e "${GREEN}Running Video Writer Tests (Release)${NC}"
+    echo "==============================================="
+
+    # Determine test executable path based on platform
+    if isWindows; then
+        WRITER_EXECUTABLE="./build/tests/Release/ccap_video_writer_test.exe"
+    else
+        WRITER_EXECUTABLE="./build/Release/tests/ccap_video_writer_test"
+    fi
+
+    if [ -f "$WRITER_EXECUTABLE" ]; then
+        echo -e "${YELLOW}Running video writer tests in Release mode...${NC}"
+
+        "$WRITER_EXECUTABLE" $GTEST_FAIL_FAST_PARAM --gtest_output=xml:build/writer_test_results_release.xml
+
+        WRITER_RESULT=$?
+
+        if [ $WRITER_RESULT -eq 0 ]; then
+            echo -e "${GREEN}✓ Video writer tests PASSED${NC}"
+        else
+            echo -e "${RED}✗ Video writer tests FAILED${NC}"
+            if [ "$EXIT_WHEN_FAILED" = true ]; then
+                echo -e "${RED}❌ Exiting due to --exit-when-failed flag${NC}"
+                exit 1
+            fi
+        fi
+    else
+        echo -e "${YELLOW}⚠ ccap_video_writer_test executable not found at $WRITER_EXECUTABLE${NC}"
+        echo -e "${YELLOW}  Video writer is only available on Windows and macOS with CCAP_ENABLE_VIDEO_WRITER=ON${NC}"
+        # Not a failure on Linux - writer is not supported there
+        WRITER_RESULT=0
+    fi
+fi
+
 echo ""
 echo "==============================================="
 echo -e "${GREEN}Test Summary${NC}"
@@ -584,6 +643,10 @@ if [ "$RUN_VIDEO" = true ] && [ $VIDEO_RESULT -ne 0 ]; then
     OVERALL_RESULT=1
 fi
 
+if [ "$RUN_WRITER" = true ] && [ $WRITER_RESULT -ne 0 ]; then
+    OVERALL_RESULT=1
+fi
+
 if [ $OVERALL_RESULT -eq 0 ]; then
     echo -e "${GREEN}🎉 All tests PASSED!${NC}"
 
@@ -601,6 +664,9 @@ if [ $OVERALL_RESULT -eq 0 ]; then
     if [ "$RUN_VIDEO" = true ]; then
         echo -e "${GREEN}  ✓ Video file playback tests (Release mode)${NC}"
     fi
+    if [ "$RUN_WRITER" = true ]; then
+        echo -e "${GREEN}  ✓ Video writer tests (Release mode)${NC}"
+    fi
 
     exit 0
 else
@@ -614,5 +680,8 @@ else
     if [ "$RUN_VIDEO" = true ] && [ $VIDEO_RESULT -ne 0 ]; then
         echo -e "${RED}  - Video file playback tests failed${NC}"
     fi
+    if [ "$RUN_WRITER" = true ] && [ $WRITER_RESULT -ne 0 ]; then
+        echo -e "${RED}  - Video writer tests failed${NC}"
+    fi
     exit 1
 fi
diff --git a/src/ccap_writer_imp.h b/src/ccap_writer_imp.h
@@ -58,18 +58,21 @@ inline uint64_t computeAutoBitRate(uint32_t width, uint32_t height, double frame
     const bool is60fps = fps > 45.0;
 
     // YouTube H.264 reference data points: (pixelCount, bitrateInMbps)
-    struct RefPoint { double pixels; double bitrateMbps; };
+    struct RefPoint {
+        double pixels;
+        double bitrateMbps;
+    };
     static const RefPoint refs30[] = {
-        {1280 * 720,  7.5},
-        {1920 * 1080, 10.0},
-        {2560 * 1440, 15.0},
-        {3840 * 2160, 30.0},
+        { 1280 * 720, 7.5 },
+        { 1920 * 1080, 10.0 },
+        { 2560 * 1440, 15.0 },
+        { 3840 * 2160, 30.0 },
     };
     static const RefPoint refs60[] = {
-        {1280 * 720,  9.0},
-        {1920 * 1080, 12.0},
-        {2560 * 1440, 24.0},
-        {3840 * 2160, 35.0},
+        { 1280 * 720, 9.0 },
+        { 1920 * 1080, 12.0 },
+        { 2560 * 1440, 24.0 },
+        { 3840 * 2160, 35.0 },
     };
 
     const RefPoint* refs = is60fps ? refs60 : refs30;
@@ -89,7 +92,8 @@ inline uint64_t computeAutoBitRate(uint32_t width, uint32_t height, double frame
     } else {
         // Between reference points: linear interpolation by pixel count
         int i = 0;
-        while (i < refCount - 1 && pixels > refs[i + 1].pixels) i++;
+        while (i < refCount - 1 && pixels > refs[i + 1].pixels)
+            i++;
         const auto& lo = refs[i];
         const auto& hi = refs[i + 1];
         double t = (pixels - lo.pixels) / (hi.pixels - lo.pixels);
@@ -102,7 +106,8 @@ inline uint64_t computeAutoBitRate(uint32_t width, uint32_t height, double frame
         const auto& r60 = refs60;
         // Average ratio across reference points
         double ratio = 0;
-        for (int i = 0; i < refCount; i++) ratio += r60[i].bitrateMbps / r30[i].bitrateMbps;
+        for (int i = 0; i < refCount; i++)
+            ratio += r60[i].bitrateMbps / r30[i].bitrateMbps;
         ratio /= refCount; // ~1.27
         double t = (fps - 30.0) / 30.0;
         bitrateMbps *= (1.0 + t * (ratio - 1.0));
