Consent not dispalying in popup

[go4cas]

@enricomarino, I have managed to implement <oath-connect-google> successfully. The element connects to Google OAuth2 service, displays the consent page, and then redirects correctly to my API to exchange the token.

The issue is that the consent page is opened in a new browser window, as opposed to a popup.

Initially I have not included the display attribute, as the default is popup. This did NOT work. I then explicitly added this attribute:

<oauth-connect-google id="oauthConnect" display="popup" exchange_url="https://path_to_my_api/auth/google" client_id="XXXXXXXXXXXXXXXX.apps.googleusercontent.com" on-response="on_response_token"></oauth-connect-google>

This did NOT make any difference.

I have checked the defaults for <oath-connect-google>, <oauth-v2> and <oauth-popup>.

Any ideas?

[go4cas]

I have printed the querystring from <oauth-v2> to the console, and can confirm that the display is indeed added to the URL:

response_type=code&client_id=XXXXXXXXXX.apps.googleusercontent.com&redirect_uri=http://localhost:8080&scope=openid profile email&display=popup

Still, the consent page is opened in a new tab, not in a popup.

[go4cas]

Okay, I've got a fix for this. Some missing code in <oauth-popup>:

    _compute_options: function (width, height, left, top) {
      var options = { width: width, height: height, left: left, top: top };
      return options;   // this was missing
    },

    _compute_options_string: function (options) {
      var string;
      var pairs = [];
      var pair;
      var key;
      var value;
      for (key in options) {
        value = options[key];
        pair = key + '=' + value;
        pairs.push(pair);   // this was missing
      }
      string = pairs.join(',');
      return string;
    },

[enricomarino]

Thanks @go4cas! If you'd like to appear as a contributor, I'll be happy to merge your pull request!