Skip to content

Commit 6a2bfe0

Browse files
committed
🐞HotFix: Parsing slack payload issue
1 parent 353e935 commit 6a2bfe0

File tree

2 files changed

+4
-10
lines changed

2 files changed

+4
-10
lines changed

src/api-utils/midddleware/parseSlackActionPayload.ts

+2-7
Original file line numberDiff line numberDiff line change
@@ -21,17 +21,14 @@ export function parseSlackActionPayload(request: Request): Lifecycle.Method {
2121
}
2222

2323
const body = new URLSearchParams(request.payload.toString('utf-8'));
24-
console.log({ body });
25-
const payload = {} as any;
26-
body.forEach((value, name) => (payload[name] = value));
24+
const payload = body.get('payload');
2725

2826
const parsed:
2927
| SlackActionsPayload
3028
| SlackDialogsPayload
3129
| SlackBlockKitPayload
3230
| SlackShortcutPayload
33-
| SlackDialogSubmissionPayload = payload;
34-
console.log('HELLO 1');
31+
| SlackDialogSubmissionPayload = JSON.parse(payload || '');
3532
let mutableSlackPayload;
3633
switch (parsed.type) {
3734
case 'message_action':
@@ -69,8 +66,6 @@ export function parseSlackActionPayload(request: Request): Lifecycle.Method {
6966
});
7067
break;
7168
}
72-
console.log('HELLO 2', { mutableSlackPayload });
7369
checkForSlackErrors(mutableSlackPayload, parsed);
74-
console.log('HELLO 3');
7570
return mutableSlackPayload.value;
7671
}

src/api-utils/midddleware/parseSlackEventPayload.ts

+2-3
Original file line numberDiff line numberDiff line change
@@ -13,10 +13,9 @@ export const parseSlackEventPayload: Lifecycle.Method = (request) => {
1313
}
1414

1515
const body = new URLSearchParams(request.payload.toString('utf-8'));
16-
const payload = {} as any;
17-
body.forEach((value, name) => (payload[name] = value));
16+
const payload = body.get('payload');
1817

19-
const parsed: SlackChallengesPayload | SlackEventsPayload = payload;
18+
const parsed: SlackChallengesPayload | SlackEventsPayload = JSON.parse(payload || '');
2019

2120
const slackEventPayload = parsed.challenge
2221
? slackChallengesPayloadSchema.validate(parsed, { stripUnknown: true })

0 commit comments

Comments
 (0)