Skip to content

Commit 2c23d46

Browse files
nickspbernardodiasckararade
authored
"Version-5.4.0" release (#534)
* Introduce UI components for "Remove Secret Tokens from URLs in XP Reg" feature (#517) * Add AccountConfirmation component (#505) * Add AccountConfirmation component * AccountConfirmation fixes * Build app * Adjust Continue button UI look Co-authored-by: Nick Plekhanov <[email protected]> * Add LocateYourProfile component (#509) * Add LocateYourProfile component * Updates on LocateYourProfile component Co-authored-by: Nick Plekhanov <[email protected]> * [CLEANUP] Automate codebase sanity check * Update css styles on the JobDetails component (#527) Co-authored-by: Bernardo Dias <[email protected]> Co-authored-by: Carlos Almeida <[email protected]>
1 parent 5cc6759 commit 2c23d46

22 files changed

+1812
-175
lines changed

.github/PULL_REQUEST_TEMPLATE.md

+2-4
Original file line numberDiff line numberDiff line change
@@ -26,21 +26,19 @@ Fixes https://x-team-internal.atlassian.net/browse/XP-__ISSUE_NUMBER__
2626

2727
## Checklist
2828

29-
**Before submitting a pull request,** please make sure the following is done:
29+
**Before submitting a Pull Request,** please make sure the following is done:
3030

31-
<!-- Remove items that do not apply. Just tick completed items in UI -->
31+
<!-- Remove items that do not apply and tick completed items in UI -->
3232
- [ ] set yourself as an assignee
3333
- [ ] set appropriate labels for a PR (`In Review` or `In Progress` depending on its status)
3434
- [ ] move respective JIRA issue to the `PEER REVIEW` column
35-
- [ ] make sure your code lints (`npm run lint`)
3635
- [ ] Flow typechecks passed (`npm run flow`)
3736
- [x] Snapshots tests passed (`npm run jest`) (**NOTE:** This is temporarily disabled. Skip it.)
3837
- [ ] check cleanup tasks (https://github.com/x-team/xp/labels/cleanup) and take a suitable small one (if exists) in a related area of the current changes
3938
- [ ] if added a new UI component that is meant to be used directly by other apps, remember to export that from the appropriate bundle file: `src/index.js` and/or `src/registration.js`
4039
- [ ] component's documentation (`.stories.js` file) is changed or added accordingly to reflect any new or updated use cases and/or debug cases
4140
- [ ] if you've fixed a bug, make sure to also include a new story that will expose declarations with problematic data that caused the bug in the first place, so that we can assure that no regressions will pop up on future interactions
4241
- [x] if any snapshots have been changed, verify that component still works and looks as expected and update the changed snapshot (**NOTE:** This is temporarily disabled. Skip it.)
43-
- [ ] once finished with all the changes, you run `npm run build` command and committed changed files to the branch
4442
- [ ] **manually tested the app** by running it in several different browsers (Firefox, Chrome, Opera, Safari, MS IE/Edge, etc.) and checked nothing is broken and operates as expected!
4543

4644
## Related PRs

lib/all.js

+12-12
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

lib/all.js.map

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

lib/editor.js

+2-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

lib/editor.js.map

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

lib/fonts.js

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

lib/fonts.js.map

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

lib/registration.js

+9-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

lib/registration.js.map

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)