Fix mypy issues

Author: tomvothecoder

tests/test_axis.py

@@ -195,16 +195,16 @@ def test_returns_dataset_dimension_coordinate_vars_using_common_var_names(
         )
 
         result = get_dim_coords(ds, "X")
-        assert result.identical(ds["lon"])
+        xr.testing.assert_identical(result, ds["lon"])
 
         result = get_dim_coords(ds, "Y")
-        assert result.identical(ds["lat"])
+        xr.testing.assert_identical(result, ds["lat"])
 
         result = get_dim_coords(ds, "T")
-        assert result.identical(ds["time"])
+        xr.testing.assert_identical(result, ds["time"])
 
         result = get_dim_coords(ds, "Z")
-        assert result.identical(ds["lev"])
+        xr.testing.assert_identical(result, ds["lev"])
 
     def test_returns_dataset_dimension_coordinate_vars_using_axis_attr(self):
         # For example, E3SM datasets might have "ilev" and "lev" dimensions
@@ -214,7 +214,7 @@ def test_returns_dataset_dimension_coordinate_vars_using_axis_attr(self):
             coords={"ilev": self.ds_axis.ilev, "lev": self.ds_axis.lev}
         )
 
-        assert result.identical(expected)
+        xr.testing.assert_identical(result, expected)
 
     def test_returns_dataset_dimension_coordinate_vars_using_standard_name_attr(self):
         # For example, E3SM datasets might have "ilev" and "lev" dimensions
@@ -223,7 +223,7 @@ def test_returns_dataset_dimension_coordinate_vars_using_standard_name_attr(self
         result = get_dim_coords(self.ds_sn, "Z")
         expected = xr.Dataset(coords={"ilev": self.ds_sn.ilev, "lev": self.ds_sn.lev})
 
-        assert result.identical(expected)
+        xr.testing.assert_identical(result, expected)
 
     def test_returns_dataarray_dimension_coordinate_var_using_axis_attr(self):
         result = get_dim_coords(self.ds_axis.hyai, "Z")

xcdat/temporal.py

@@ -1398,8 +1398,8 @@ def _drop_incomplete_djf(self, dataset: xr.Dataset) -> xr.Dataset:
         # method concatenates the time dimension to non-time dimension data
         # vars, which is not a desired behavior.
         ds = dataset.copy()
-        ds_time = ds.get([v for v in ds.data_vars if self.dim in ds[v].dims])
-        ds_no_time = ds.get([v for v in ds.data_vars if self.dim not in ds[v].dims])
+        ds_time = ds[[v for v in ds.data_vars if self.dim in ds[v].dims]]
+        ds_no_time = ds[[v for v in ds.data_vars if self.dim not in ds[v].dims]]
 
         start_year, end_year = (
             ds[self.dim].dt.year.values[0],