fix: Previously, when batch processing images with "Keep original format" selected alongside compression or resizing, files would be incorrectly renamed to a .original extension (e.g., photo.png → photo.original), breaking links and file recognition. Files now retain their original extension while still being compressed/resized.

Author: xRyul

src/BatchImageProcessor.ts

@@ -119,8 +119,9 @@ export class BatchImageProcessor {
 
                 // Capture paths up-front so we can safely revert if needed
                 const oldPath = linkedFile.path;
-                const newFileName = `${linkedFile.basename}.${outputFormat.toLowerCase()}`;
-                const newFilePath = linkedFile.path.replace(linkedFile.name, newFileName);
+                // When outputFormat is ORIGINAL, keep the original filename (no rename)
+                const newFileName = outputFormat === 'ORIGINAL' ? linkedFile.name : `${linkedFile.basename}.${outputFormat.toLowerCase()}`;
+                const newFilePath = outputFormat === 'ORIGINAL' ? linkedFile.path : linkedFile.path.replace(linkedFile.name, newFileName);
 
                 let didRename = false;
                 let didWrite = false;
@@ -298,8 +299,9 @@ export class BatchImageProcessor {
                 imageCount++;
 
                 const oldPath = image.path;
-                const newFileName = `${image.basename}.${outputFormat.toLowerCase()}`;
-                const newFilePath = image.path.replace(image.name, newFileName);
+                // When outputFormat is ORIGINAL, keep the original filename (no rename)
+                const newFileName = outputFormat === 'ORIGINAL' ? image.name : `${image.basename}.${outputFormat.toLowerCase()}`;
+                const newFilePath = outputFormat === 'ORIGINAL' ? image.path : image.path.replace(image.name, newFileName);
 
                 let didRename = false;
                 let didWrite = false;
@@ -472,8 +474,9 @@ export class BatchImageProcessor {
                 imageCount++;
 
                 const oldPath = image.path;
-                const targetName = `${image.basename}.${outputFormat.toLowerCase()}`;
-                let targetPath = image.path.replace(image.name, targetName);
+                // When outputFormat is ORIGINAL, keep the original filename (no rename)
+                const targetName = outputFormat === 'ORIGINAL' ? image.name : `${image.basename}.${outputFormat.toLowerCase()}`;
+                let targetPath = outputFormat === 'ORIGINAL' ? image.path : image.path.replace(image.name, targetName);
 
                 let didRename = false;
                 let didWrite = false;
@@ -698,8 +701,9 @@ export class BatchImageProcessor {
                     );
 
                     // Construct the new file path based on conversion settings
-                    const newFileName = `${image.basename}.${outputFormat.toLowerCase()}`;
-                    let newFilePath = image.path.replace(image.name, newFileName);
+                    // When outputFormat is ORIGINAL, keep the original filename (no rename)
+                    const newFileName = outputFormat === 'ORIGINAL' ? image.name : `${image.basename}.${outputFormat.toLowerCase()}`;
+                    let newFilePath = outputFormat === 'ORIGINAL' ? image.path : image.path.replace(image.name, newFileName);
 
                     // Check for conflicts and generate unique name if necessary using FolderAndFilenameManagement
                     if (

tests/integration/batch/ProcessAllVault.test.ts

@@ -120,6 +120,53 @@ describe('BatchImageProcessor — Vault-wide orchestration', () => {
     expect(folderAndFilenameManagement.handleNameConflicts).toHaveBeenCalled();
   });
 
+  it('4.12 Given convertTo=disabled (ORIGINAL), When processing, Then files are NOT renamed', async () => {
+    // Fresh isolated environment with convertTo=disabled
+    const noteFile = fakeTFile({ path: 'notes/test.md' });
+    const pngImage = fakeTFile({ path: 'images/photo.png' });
+    const jpgImage = fakeTFile({ path: 'images/picture.jpg' });
+    const vaultIso = fakeVault({ files: [noteFile, pngImage, jpgImage] }) as any;
+    const appIso = fakeApp({
+      vault: vaultIso,
+      metadataCache: { resolvedLinks: { [noteFile.path]: { [pngImage.path]: 1, [jpgImage.path]: 1 } } } as any
+    }) as any;
+    appIso.fileManager = { renameFile: vi.fn(async (file: any, newPath: string) => { await appIso.vault.rename(file, newPath); }) };
+
+    // convertTo=disabled means keep original format - set ALL required settings explicitly
+    const pluginIso = makePluginStub({
+      settings: {
+        ProcessAllVaultconvertTo: 'disabled',
+        ProcessAllVaultquality: 0.8, // compression applied (not 1, so processing should occur)
+        ProcessAllVaultResizeModalresizeMode: 'None',
+        ProcessAllVaultResizeModaldesiredWidth: 0,
+        ProcessAllVaultResizeModaldesiredHeight: 0,
+        ProcessAllVaultResizeModaldesiredLength: 0,
+        ProcessAllVaultEnlargeOrReduce: 'Always',
+        allowLargerFiles: true,
+        ProcessAllVaultSkipFormats: '',
+        ProcessAllVaultskipImagesInTargetFormat: false // Important: don't skip images in their own format
+      }
+    });
+    const imgIso = { processImage: vi.fn(async (_blob: Blob) => new ArrayBuffer(4)) };
+    const ffmIso = { handleNameConflicts: vi.fn(async (_dir: string, name: string) => name) };
+    const bipIso = new BatchImageProcessor(appIso as any, pluginIso as any, imgIso as any, ffmIso as any);
+
+    await bipIso.processAllVaultImages();
+
+    // Images should be processed (compression applied)
+    expect(imgIso.processImage).toHaveBeenCalled();
+
+    // But NO renames should have occurred - files keep their original extensions
+    expect(appIso.fileManager.renameFile).not.toHaveBeenCalled();
+
+    // Verify the files still exist with original names
+    expect(appIso.vault.getAbstractFileByPath('images/photo.png')).toBeTruthy();
+    expect(appIso.vault.getAbstractFileByPath('images/picture.jpg')).toBeTruthy();
+    // And NOT renamed to .original
+    expect(appIso.vault.getAbstractFileByPath('images/photo.original')).toBeFalsy();
+    expect(appIso.vault.getAbstractFileByPath('images/picture.original')).toBeFalsy();
+  });
+
   it('4.10 Skip target format (vault): when convertTo=webp and skipImagesInTargetFormat=true, webp files are skipped', async () => {
     // Fresh, isolated environment to avoid mutated TFile state across tests
     const noteFile = fakeTFile({ path: 'notes/m.md' });