Write a test to check handling of duplicate invoice numbers and fix view

Author: xam-ps

app/Http/Controllers/RevenueController.php

@@ -36,7 +36,7 @@ public function store(Request $request)
             $revenue->save();
         } catch (QueryException $e) {
             if ($e->errorInfo[1] == 1062) { // 1062 is the MySQL error code for a duplicate entry
-                return redirect()->back()->withInput()->withErrors(['unique_column' => 'The value for Rechnungsnummer must be unique.']);
+                return redirect()->back()->withInput()->withErrors(['unique_column' => 'Die Rechnungsnummer existiert bereits.']);
             }
             throw $e;
         }

resources/views/components/revenue-form.blade.php

@@ -34,7 +34,7 @@
         </datalist>
 
         <label for="invoice_number">Rechnungsnummer:</label><br>
-        @error('invoice_number')
+        @error('unique_column')
         <div class="alert">{{ $message }}</div>
         @enderror
         <input id="invoice_number" name="invoice_number"

tests/Feature/RevenueTest.php

@@ -115,4 +115,22 @@ public function test_overview_page_shows_correct_total_for_multiple_revenues():
         $response->assertSee($formatEuro($totalTax));
         $response->assertSee($formatEuro($totalGross));
     }
+
+    // A test, that checks if an error message is shown, when trying to create a revenue with a duplicate invoice number
+    public function test_store_revenue_with_duplicate_invoice_number_shows_error_message(): void
+    {
+        $user = User::factory()->create();
+        $revenue = Revenue::factory()->createOne(['invoice_number' => '12345678']);
+        $formData = Revenue::factory()->makeOne(['invoice_number' => '123456789'])->toArray();
+        $formData['billing_date'] = '2021-01-01';
+        $formData['payment_date'] = '2021-01-01';
+
+        $response = $this->actingAs($user)
+            ->post('/revenue', $formData);
+
+        $response->assertSessionHasErrors(['unique_column' => 'Die Rechnungsnummer existiert bereits.']);
+
+        $revenue->delete();
+        $user->delete();
+    }
 }