Skip to content
This repository was archived by the owner on May 1, 2024. It is now read-only.

Commit 88b70ad

Browse files
jsuarezruizrachelkangjfversluis
authored
[Android] Fixed brush background issue scrolling ListView (#13402)
* Fixed brush background issue scrolling ListView on Android * Update Issue13392.xaml.cs --------- Co-authored-by: Rachel Kang <[email protected]> Co-authored-by: Gerald Versluis <[email protected]>
1 parent 6293975 commit 88b70ad

File tree

4 files changed

+87
-0
lines changed

4 files changed

+87
-0
lines changed
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,57 @@
1+
<?xml version="1.0" encoding="utf-8" ?>
2+
<local:TestContentPage
3+
xmlns="http://xamarin.com/schemas/2014/forms"
4+
xmlns:x="http://schemas.microsoft.com/winfx/2009/xaml"
5+
xmlns:d="http://xamarin.com/schemas/2014/forms/design"
6+
xmlns:mc="http://schemas.openxmlformats.org/markup-compatibility/2006"
7+
mc:Ignorable="d"
8+
Title="Test 13392" xmlns:local="using:Xamarin.Forms.Controls"
9+
x:Class="Xamarin.Forms.Controls.Issues.Issue13392">
10+
<StackLayout>
11+
<Label
12+
Padding="12"
13+
BackgroundColor="Black"
14+
TextColor="White"
15+
Text="Scroll the ListView to the end, if all the cells have a gradient background test has passed."/>
16+
<ListView
17+
RowHeight="200">
18+
<ListView.ItemsSource>
19+
<x:Array Type="{x:Type x:String}">
20+
<x:String>Item 1</x:String>
21+
<x:String>Item 2</x:String>
22+
<x:String>Item 3</x:String>
23+
<x:String>Item 4</x:String>
24+
<x:String>Item 5</x:String>
25+
<x:String>Item 6</x:String>
26+
<x:String>Item 7</x:String>
27+
<x:String>Item 8</x:String>
28+
<x:String>Item 9</x:String>
29+
<x:String>Item 10</x:String>
30+
</x:Array>
31+
</ListView.ItemsSource>
32+
<ListView.ItemTemplate>
33+
<DataTemplate>
34+
<ViewCell Height="300">
35+
<Frame Margin="10,7,7,0" CornerRadius="5" HasShadow="True">
36+
<Frame.Background>
37+
<LinearGradientBrush StartPoint="0,0" EndPoint="1,1">
38+
<GradientStop Color="#0039AC" Offset="0.1"/>
39+
<GradientStop Color="#004CDD" Offset="0.5"/>
40+
<GradientStop Color="#3476FC" Offset="1.0"/>
41+
</LinearGradientBrush>
42+
</Frame.Background>
43+
<Grid>
44+
<Label
45+
Text="{Binding}"
46+
TextColor="White"
47+
FontSize="Medium"
48+
VerticalOptions="Center"
49+
HorizontalOptions="Center" />
50+
</Grid>
51+
</Frame>
52+
</ViewCell>
53+
</DataTemplate>
54+
</ListView.ItemTemplate>
55+
</ListView>
56+
</StackLayout>
57+
</local:TestContentPage>
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,25 @@
1+
using Xamarin.Forms.CustomAttributes;
2+
3+
#if UITEST
4+
using Xamarin.UITest;
5+
using NUnit.Framework;
6+
using Xamarin.Forms.Core.UITests;
7+
#endif
8+
9+
namespace Xamarin.Forms.Controls.Issues
10+
{
11+
[Issue(IssueTracker.Github, 13392, "[Bug] Brush dissappear after scroll in ListView on Android", PlatformAffected.Android)]
12+
public partial class Issue13392 : TestContentPage
13+
{
14+
public Issue13392()
15+
{
16+
#if APP
17+
InitializeComponent();
18+
#endif
19+
}
20+
21+
protected override void Init()
22+
{
23+
}
24+
}
25+
}

Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Xamarin.Forms.Controls.Issues.Shared.projitems

+4
Original file line numberDiff line numberDiff line change
@@ -1806,6 +1806,7 @@
18061806
<Compile Include="$(MSBuildThisFileDirectory)ShellFlyoutBackground.cs" />
18071807
<Compile Include="$(MSBuildThisFileDirectory)ShellFlyoutContentOffest.cs" />
18081808
<Compile Include="$(MSBuildThisFileDirectory)ShellFlyoutContentWithZeroMargin.cs" />
1809+
<Compile Include="$(MSBuildThisFileDirectory)Issue13392.xaml.cs" />
18091810
<Compile Include="$(MSBuildThisFileDirectory)Issue13100.xaml.cs" />
18101811
<Compile Include="$(MSBuildThisFileDirectory)Issue13337.xaml.cs" />
18111812
<Compile Include="$(MSBuildThisFileDirectory)Issue13232.xaml.cs" />
@@ -2293,6 +2294,9 @@
22932294
<EmbeddedResource Include="$(MSBuildThisFileDirectory)Issue13136.xaml">
22942295
<Generator>MSBuild:UpdateDesignTimeXaml</Generator>
22952296
</EmbeddedResource>
2297+
<EmbeddedResource Include="$(MSBuildThisFileDirectory)Issue13392.xaml">
2298+
<Generator>MSBuild:UpdateDesignTimeXaml</Generator>
2299+
</EmbeddedResource>
22962300
<EmbeddedResource Include="$(MSBuildThisFileDirectory)Issue13173.xaml">
22972301
<Generator>MSBuild:UpdateDesignTimeXaml</Generator>
22982302
</EmbeddedResource>

Xamarin.Forms.Platform.Android/FastRenderers/FrameRenderer.cs

+1
Original file line numberDiff line numberDiff line change
@@ -191,6 +191,7 @@ protected virtual void OnElementChanged(ElementChangedEventArgs<Frame> e)
191191
e.NewElement.PropertyChanged += OnElementPropertyChanged;
192192
UpdateShadow();
193193
UpdateBackgroundColor();
194+
UpdateBackground();
194195
UpdateCornerRadius();
195196
UpdateBorderColor();
196197
UpdateClippedToBounds();

0 commit comments

Comments
 (0)