From 058c84513815bd73b601eb2b0fff19841cb505c9 Mon Sep 17 00:00:00 2001
From: Mark Syms <mark.syms@cloud.com>
Date: Thu, 17 Apr 2025 10:39:02 +0100
Subject: [PATCH] CA-409648: fix some resource leaks

Signed-off-by: Mark Syms <mark.syms@cloud.com>
---
 control/tap-ctl-allocate.c | 2 +-
 control/tap-ctl-free.c     | 2 +-
 drivers/tapdisk-vbd.c      | 2 ++
 3 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/control/tap-ctl-allocate.c b/control/tap-ctl-allocate.c
index 3e0b39f8..452b217d 100644
--- a/control/tap-ctl-allocate.c
+++ b/control/tap-ctl-allocate.c
@@ -130,7 +130,7 @@ tap_ctl_allocate_minor(int *minor, char **minor_name)
 	if (err == -1) {
 		err = -errno;
 		EPRINTF("Failed to lock runtime directory %d\n", errno);
-		return err;
+		goto out;
 	}
 
 	for (id=0; id<MAX_ID; id++) {
diff --git a/control/tap-ctl-free.c b/control/tap-ctl-free.c
index fe246244..a9ed7081 100644
--- a/control/tap-ctl-free.c
+++ b/control/tap-ctl-free.c
@@ -60,7 +60,7 @@ tap_ctl_free(const int minor)
 	if (err == -1) {
 		err = -errno;
 		EPRINTF("Failed to lock runtime directory %d\n", errno);
-		return err;
+		goto out;
 	}
 
 	err = asprintf(&path, "%s/tapdisk-%d", BLKTAP2_NP_RUN_DIR, minor);
diff --git a/drivers/tapdisk-vbd.c b/drivers/tapdisk-vbd.c
index a68d1e42..09b0c7de 100644
--- a/drivers/tapdisk-vbd.c
+++ b/drivers/tapdisk-vbd.c
@@ -683,6 +683,8 @@ open_vbd_marker(int id)
        goto out;
    }
 
+   free(path);
+
    return fid;
 
 out: