fix(godoc-lint): fix golangci-lint version-detection regex

The v1.1.5 v2-compat patch used `sed -n 's/.*version v\([0-9]\+\).*/\1/p'`,
which (a) requires the `v` prefix that current `golangci-lint version` output
no longer emits (`golangci-lint has version 2.12.2 built with ...`) and
(b) uses `\{0,1\}` quantifier in BRE that BSD sed on macOS doesn't accept.
Switched to `sed -E -n 's/.*version v?([0-9]+).*/\1/p'` (ERE; `v` optional).

Without this, every consumer with golangci-lint v2.x falls through to the
`--disable-all` branch and trips "unknown flag" again. Surfaced on
html-to-markdown's prek run after the v1.1.5 bump.

Author: Goldziher

CHANGELOG.md

@@ -9,6 +9,16 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### Fixed
 
+- `godoc-lint`: fix `golangci-lint` version-detection regex. The v1.1.5
+  v2-compat patch used `sed -n 's/.*version v\([0-9]\+\).*/\1/p'`, which
+  (a) requires the `v` prefix that current `golangci-lint version` output
+  no longer emits (`golangci-lint has version 2.12.2 built with ...`) and
+  (b) uses `\{0,1\}` quantifier in BRE that BSD sed on macOS doesn't accept.
+  Switched to `sed -E -n 's/.*version v?([0-9]+).*/\1/p'` (ERE; `v` optional).
+  Without this, every consumer with golangci-lint v2.x falls through to the
+  `--disable-all` branch and trips "unknown flag" again. Surfaced on
+  html-to-markdown's prek run after the v1.1.5 bump. (`hooks/godoc-lint/run.sh`)
+
 - `godoc-lint`: support `golangci-lint` v2.x. v2 removed the `--disable-all`
   flag in favour of `--default=none`, so v1.1.4 and earlier failed with
   "unknown flag: --disable-all" against v2 installations. The hook now

hooks/godoc-lint/run.sh

@@ -34,7 +34,10 @@ if command -v golangci-lint >/dev/null 2>&1; then
   # v2 removed `--disable-all` and replaced it with `--default=none`. Detect
   # the major version once and pick the matching flag set so this hook works
   # against both v1.x and v2.x consumers.
-  glc_major="$(golangci-lint version 2>&1 | sed -n 's/.*version v\([0-9]\+\).*/\1/p' | head -n 1)"
+  # `golangci-lint version` prints e.g. "golangci-lint has version 2.12.2 built with ..."
+  # (no `v` prefix). Match the first integer immediately after the literal "version ".
+  # Use `sed -E` (extended regex) — BSD sed on macOS doesn't support `\{0,1\}` quantifier in BRE.
+  glc_major="$(golangci-lint version 2>&1 | sed -E -n 's/.*version v?([0-9]+).*/\1/p' | head -n 1)"
   if [[ "${glc_major}" =~ ^[0-9]+$ ]] && ((glc_major >= 2)); then
     only_revive_args=(--default=none --enable=revive)
   else