fixup: create/delete array at caller, esnure null-termination

Author: wutschel

XBMC Remote/SettingsValuesViewController.m

@@ -372,10 +372,13 @@ - (NSString*)getStringForSliderItem:(id)item value:(int)value {
         stringResult = [NSString stringWithFormat:format, value];
     }
     else {
+        // Allocate fmtOutput here to use automatic dellocation once method is finished
+        char fmtOutput[64];
+        
         // Since Kodi 18.x fmt formatting ("{0:d} ms") is used.
-        const char *formatStr = [format UTF8String];
-        char *string = convert_fmt(formatStr, value);
-        stringResult = [NSString stringWithUTF8String:string];
+        const char *fmtFormat = [format UTF8String];
+        convert_fmt(fmtOutput, sizeof(fmtOutput), fmtFormat, value);
+        stringResult = [NSString stringWithUTF8String:fmtOutput];
     }
     return stringResult;
 }

XBMC Remote/convert_fmt.cpp

@@ -9,9 +9,10 @@
 #include "convert_fmt.hpp"
 #include <fmt/core.h>
 
-char* convert_fmt(const char *format, int value) {
-    static char s[128];
-    memset(s, 0, sizeof(s));
-    fmt::format_to(s, format, value);
-    return s;
+void convert_fmt(char *output, int size, const char *format, int value) {
+    // Initialize char array with zeros
+    memset(output, 0, size);
+    
+    // Only fill up to size-1 to esnure null-termination
+    fmt::format_to_n(output, size - 1, format, value);
 }

XBMC Remote/convert_fmt.hpp

@@ -12,7 +12,7 @@
 extern "C" {
 #endif
 
-extern char* convert_fmt(const char *format, int value);
+extern void convert_fmt(char *io, int size, const char *format, int value);
 
 #ifdef __cplusplus
 }