|
| 1 | +From 7034c039d092ade9ce6eef37f1a249289fd42a88 Mon Sep 17 00:00:00 2001 |
| 2 | +From: Mathieu Labourier <mathieu.labourier@vates.tech> |
| 3 | +Date: Mon, 17 Aug 2026 15:08:15 +0200 |
| 4 | +Subject: [PATCH] fix: skip cbtlog disks in commit related operations |
| 5 | + |
| 6 | +This prevents a bug where tapdisk will return a cbtlog |
| 7 | +disk in commit related operations, causing them to fail early |
| 8 | +since the cbtlog driver doesn't include a commit action |
| 9 | + |
| 10 | +Signed-off-by: Mathieu Labourier <mathieu.labourier@vates.tech> |
| 11 | +--- |
| 12 | + drivers/tapdisk-vbd.c | 18 +++++++++++++++--- |
| 13 | + 1 file changed, 15 insertions(+), 3 deletions(-) |
| 14 | + |
| 15 | +diff --git a/drivers/tapdisk-vbd.c b/drivers/tapdisk-vbd.c |
| 16 | +index 8fcabbbd..7b5171cd 100644 |
| 17 | +--- a/drivers/tapdisk-vbd.c |
| 18 | ++++ b/drivers/tapdisk-vbd.c |
| 19 | +@@ -167,6 +167,18 @@ tapdisk_vbd_first_image(td_vbd_t *vbd) |
| 20 | + return image; |
| 21 | + } |
| 22 | + |
| 23 | ++static inline td_image_t * |
| 24 | ++tapdisk_vbd_first_non_log_image(td_vbd_t *vbd) |
| 25 | ++{ |
| 26 | ++ td_image_t *image = NULL, *tmp; |
| 27 | ++ |
| 28 | ++ tapdisk_vbd_for_each_image(vbd, image, tmp) |
| 29 | ++ if (image->type != DISK_TYPE_LOG) |
| 30 | ++ return image; |
| 31 | ++ |
| 32 | ++ return image; |
| 33 | ++} |
| 34 | ++ |
| 35 | + static inline td_image_t * |
| 36 | + tapdisk_vbd_last_image(td_vbd_t *vbd) |
| 37 | + { |
| 38 | +@@ -1146,7 +1158,7 @@ tapdisk_vbd_commit(td_vbd_t *vbd, const char *name) |
| 39 | + INFO("commit %s\n", name); |
| 40 | + } |
| 41 | + |
| 42 | +- err = td_commit(tapdisk_vbd_first_image(vbd), name); |
| 43 | ++ err = td_commit(tapdisk_vbd_first_non_log_image(vbd), name); |
| 44 | + |
| 45 | + INFO("commit started (%d)\n", err); |
| 46 | + |
| 47 | +@@ -1162,7 +1174,7 @@ tapdisk_vbd_query_commit_job(td_vbd_t *vbd, td_query_t *query) |
| 48 | + INFO("query commit job.\n"); |
| 49 | + } |
| 50 | + |
| 51 | +- err = td_query_commit_job(tapdisk_vbd_first_image(vbd), query); |
| 52 | ++ err = td_query_commit_job(tapdisk_vbd_first_non_log_image(vbd), query); |
| 53 | + |
| 54 | + INFO("query commit job (%d)\n", err); |
| 55 | + |
| 56 | +@@ -1178,7 +1190,7 @@ tapdisk_vbd_cancel_commit_job(td_vbd_t *vbd, bool wait) |
| 57 | + INFO("cancel commit job.\n"); |
| 58 | + } |
| 59 | + |
| 60 | +- err = td_cancel_commit_job(tapdisk_vbd_first_image(vbd), wait); |
| 61 | ++ err = td_cancel_commit_job(tapdisk_vbd_first_non_log_image(vbd), wait); |
| 62 | + |
| 63 | + INFO("cancel commit job (%d)\n", err); |
| 64 | + |
0 commit comments