check the xapi version in the installer

Signed-off-by: Gaëtan Lehmann <gaetan.lehmann@vates.tech>

Author: glehmann

backend.py

@@ -10,6 +10,7 @@
 import re
 import tempfile
 
+import rpm
 import repository
 import generalui
 import xelogging
@@ -161,7 +162,7 @@ def getPrepSequence(ans, interactive):
 
 def getMainRepoSequence(ans, repos):
     seq = []
-    seq.append(Task(repository.installFromRepos, lambda a: [repos] + [a.get('mounts'), a.get('kernel-alt'), a.get('linstor-version')], [],
+    seq.append(Task(repository.installFromRepos, lambda a: [repos] + [a.get('mounts'), a.get('kernel-alt'), a.get('linstor-version'), a.get('xapi-version')], [],
                 progress_scale=100,
                 pass_progress_callback=True,
                 progress_text="Installing %s..." % (", ".join([repo.name() for repo in repos]))))
@@ -440,6 +441,19 @@ def performInstallation(answers, ui_package, interactive):
                                "latest dedicated ISO." %
                                (answers['linstor-version'], ', '.join(available_linstor_versions)))
 
+    # if upgrading a host with xapi, check we can upgrade it first
+    if answers['install-type'] == INSTALL_TYPE_REINSTALL and answers['xapi-version']:
+        available_xapi_versions = repository.listPackagesFromRepos(
+            main_repositories, 'xapi-core', '%{evr}', latest_only=True)
+        if not available_xapi_versions:
+            raise RuntimeError("No XAPI package found in package source")
+        assert len(available_xapi_versions) == 1
+        if rpm.labelCompare(('pkg', 'arch', available_xapi_versions[0]), ('pkg', 'arch', answers['xapi-version'])) < 0:
+            raise RuntimeError("Cannot upgrade the host: the XAPI version on the host (%s) "
+                               "is newer than the XAPI version to install (%s). "
+                               "Please refer to the XCP-ng upgrade documentation." %
+                               (answers['xapi-version'], available_xapi_versions[0]))
+
     # perform installation:
     prep_seq = getPrepSequence(answers, interactive)
     executeSequence(prep_seq, "Preparing for installation...", answers, ui_package, False)

product.py

@@ -48,6 +48,14 @@ def getLinstorVersion(rootfs_mount):
         return None
     return out
 
+def getXapiVersion(rootfs_mount):
+    """ Returns the package version of the xapi packages"""
+    command = ['rpm', '--root', rootfs_mount, '-q', '--qf', '%{evr}', 'xapi-core']
+    rc, out = util.runCmd2(command, with_stdout=True)
+    if rc != 0:
+        return None
+    return out
+
 class ExistingInstallation:
     def __init__(self, primary_disk, boot_device, state_device):
         self.primary_disk = primary_disk
@@ -388,6 +396,9 @@ def fetchIfaceInfoFromNetworkdbAsDict(bridge, iface=None):
             results['linstor-version'] = getLinstorVersion(self.state_fs.mount_point) or None
             logger.info("LINSTOR version detected: %s" % (results['linstor-version'],))
 
+            results['xapi-version'] = getXapiVersion(self.state_fs.mount_point) or None
+            logger.info("xapi version detected: %s" % (results['xapi-version'],))
+
         finally:
             self.unmount_state()
 

upgrade.py

@@ -608,7 +608,7 @@ def replace_config(config_file, destination):
             primary_fs.unmount()
 
     prepUpgradeArgs = []
-    prepStateChanges = ['installation-uuid', 'control-domain-uuid', 'management-address-type', 'linstor-version']
+    prepStateChanges = ['installation-uuid', 'control-domain-uuid', 'management-address-type', 'linstor-version', 'xapi-version']
     def prepareUpgrade(self, progress_callback):
         """ Try to preserve the installation and control-domain UUIDs from
         xensource-inventory."""
@@ -619,7 +619,7 @@ def prepareUpgrade(self, progress_callback):
         except KeyError:
             raise RuntimeError("Required information (INSTALLATION_UUID, CONTROL_DOMAIN_UUID, MANAGEMENT_ADDRESS_TYPE) was missing from your xensource-inventory file.  Aborting installation; please replace these keys and try again.")
 
-        return installID, controlID, mgmtAddrType, self.source.settings['linstor-version']
+        return installID, controlID, mgmtAddrType, self.source.settings['linstor-version'], self.source.settings['xapi-version']
 
     def buildRestoreList(self, src_base):
         restore_list = []