feat(filesr): support vdi_revert on FileSR

* Support vdi_revert from xapi
* Enable VDI_REVERT capability on FileSR
* Implement vdi revert on File based SRs
* Support CBT on vdi revert
* Support vdi_revert rollback with journal in case of catastrophic failure
* Fix ZFSSR tests
* Add `tap_pause` context manager to base `VDI` object
* add generic journaling capabilities
* Fix permission on nfs-on-slave plugin

Signed-off-by: Antoine Bartuccio <antoine.bartuccio@vates.tech>

Author: klmp200

Makefile

@@ -56,6 +56,7 @@ SM_LIBS += mpathcount
 SM_LIBS += refcounter
 SM_LIBS += journaler
 SM_LIBS += fjournaler
+SM_LIBS += jutils
 SM_LIBS += lock
 SM_LIBS += flock
 SM_LIBS += lock_queue

drivers/CephFSSR.py

@@ -45,7 +45,7 @@
                 "VDI_CREATE", "VDI_DELETE", "VDI_ATTACH", "VDI_DETACH",
                 "VDI_UPDATE", "VDI_CLONE", "VDI_SNAPSHOT", "VDI_RESIZE", "VDI_MIRROR",
                 "VDI_GENERATE_CONFIG",
-                "VDI_RESET_ON_BOOT/2", "ATOMIC_PAUSE"]
+                "VDI_RESET_ON_BOOT/2", "ATOMIC_PAUSE", "VDI_REVERT"]
 
 CONFIGURATION = [
     ['server', 'Ceph server(s) (required, ex: "192.168.0.12" or "10.10.10.10,10.10.10.26")'],
@@ -120,6 +120,7 @@ def load(self, sr_uuid) -> None:
         self.linkpath = os.path.join(self.mountpoint, sr_uuid or "")
         self.path = os.path.join(SR.MOUNT_BASE, sr_uuid)
         self._check_o_direct()
+        self._undo_all_journals()
 
     def checkmount(self):
         return util.ioretry(lambda: ((util.pathexists(self.mountpoint) and

drivers/EXTSR.py

@@ -38,7 +38,8 @@
                 "VDI_UPDATE", "VDI_CLONE", "VDI_SNAPSHOT", "VDI_RESIZE", "VDI_MIRROR",
                 "VDI_GENERATE_CONFIG",
                 "VDI_RESET_ON_BOOT/2", "ATOMIC_PAUSE", "VDI_CONFIG_CBT",
-                "VDI_ACTIVATE", "VDI_DEACTIVATE", "THIN_PROVISIONING", "VDI_READ_CACHING"]
+                "VDI_ACTIVATE", "VDI_DEACTIVATE", "THIN_PROVISIONING", "VDI_READ_CACHING",
+                "VDI_REVERT"]
 
 CONFIGURATION = [['device', 'local device path (required) (e.g. /dev/sda3)']]
 
@@ -75,6 +76,7 @@ def load(self, sr_uuid) -> None:
         self.remotepath = os.path.join("/dev", self.vgname, sr_uuid)
         self.attached = self._checkmount()
         self.driver_config = DRIVER_CONFIG
+        self._undo_all_journals()
 
     @override
     def delete(self, sr_uuid) -> None: