Better name for backup invalidation and mypy handling of a (im)possible None self._linstor

Signed-off-by: Arnaud Garcia-Fernandez <arnaud.garcia-fernandez@vates.tech>

Author: Ythogtha

drivers/LinstorSR.py

@@ -826,7 +826,7 @@ def check_sr(self, sr_uuid) -> None:
             return
         # Validate and clean previous backups if necessary.
         # -> Needs access to backup files, available only on the Controller.
-        LinstorVolumeManager.database_invalidation()
+        LinstorVolumeManager.database_backup_validate_and_prune()
         # check_sr is launched on *all* hosts, but it turns out that
         # we do not want all of them to blindly generate concurrencing backups.
         # Hence we must choose one, either one is good, but there must be only one.
@@ -1597,7 +1597,8 @@ def database_backup(self, name: Literal["auto", "create", "delete", "snapshot"])
         if not self._linstor:
             self._reconnect()
         try:
-            self._linstor.database_backup(name)  # type: ignore
+            assert self._linstor
+            self._linstor.database_backup(name)
         except Exception as e:
             util.SMlog(
                 f"[database_backup] Error during creation: {e}",

drivers/linstorvolumemanager.py

@@ -1808,7 +1808,7 @@ def database_backup(self, name=""):
         util.SMlog(f"[database_backup] Created: {filename}", priority=util.LOG_INFO)
 
     @classmethod
-    def database_invalidation(cls):
+    def database_backup_validate_and_prune(cls):
         """
         Removes old backup based on two criterias:
         - Validity of the zipfile done by self._check_database_backup.