fixes

Signed-off-by: Ronan Abhamon <ronan.abhamon@vates.tech>

Author: Wescoeur

drivers/linstor-manager

@@ -47,7 +47,7 @@ LVM_PLUGIN = 'lvm.py'
 THIN_POOL = 'thin_pool'
 
 FIREWALL_PORT_SCRIPT = '/etc/xapi.d/plugins/firewall-port'
-LINSTOR_PORTS = [LINSTOR_SATELLITE_PORT, 3370, 3376, 3377, 8076, 8077]
+LINSTOR_PORTS = (LINSTOR_SATELLITE_PORT, 3370, 3376, 3377, 8076, 8077)
 DRBD_PORTS = '7000:8000'
 
 DRBD_REACTOR_CONF = '/etc/drbd-reactor.d/sm-linstor.toml'

drivers/linstorvolumemanager.py

@@ -139,13 +139,15 @@ def _get_controller_addresses() -> List[str]:
         (ret, stdout, stderr) = util.doexec([
             "/usr/sbin/ss", "-tnpH", "state", "established", f"( sport = :{LINSTOR_SATELLITE_PORT} )"
         ])
-        return [
-            line.split()[3].split(":")[0]
-            for line in stdout.splitlines()
-        ]
+        if ret == 0:
+            return [
+                line.split()[3].rsplit(":", 1)[0]
+                for line in stdout.splitlines()
+            ]
+        util.SMlog(f"Unexpected code {ret}: {stderr}")
     except Exception as e:
         util.SMlog(f"Unable to get controller addresses: {e}")
-        return []
+    return []
 
 def _get_controller_uri() -> str:
     # TODO: Check that an IP address from the current pool is returned.
@@ -160,7 +162,7 @@ def get_controller_uri():
             return uri
 
         retries += 1
-        if retries >= 10:
+        if retries >= 30:
             break
         time.sleep(1)