Skip to content

Commit 542072d

Browse files
committed
CA-407343: do not remove the VHD parent property after leaf coalesce
Long standing bug, introduced in ``` changeset: 1508:3c5a651ef2e4 user: Andrei Lifchits <andrei.lifchits@citrix.com> date: Wed Feb 10 09:41:59 2010 -0800 summary: CA-36637: fix the free space requirements calculation for the inline- and leaf-coalesce; plus: ``` The act of coalescing a leaf VHD into a parent does not make any structural changes to the parentage of the VHD into which the data has been coalesced. This, unnecessarily, introduced a race where a VDI would report not having a parent until the next SR scan fixed it up. Signed-off-by: Mark Syms <mark.syms@cloud.com>
1 parent 3ecfefa commit 542072d

1 file changed

Lines changed: 0 additions & 1 deletion

File tree

libs/sm/cleanup.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2316,7 +2316,6 @@ def _doCoalesceLeaf(self, vdi):
23162316
# garbage
23172317

23182318
# update the VDI record
2319-
vdi.parent.delConfig(VDI.DB_VHD_PARENT)
23202319
if vdi.parent.raw:
23212320
vdi.parent.setConfig(VDI.DB_VDI_TYPE, vhdutil.VDI_TYPE_RAW)
23222321
vdi.parent.delConfig(VDI.DB_VHD_BLOCKS)

0 commit comments

Comments
 (0)