fix(linstor): handle non-existing volumes when updating UUID

We may update the UUID of a volume that does not actually exist. This
happens when rolling back a clone operation that failed because the
physical volume could not be created.

This updates the `update_volume_uuid` function to save the `not-exists`
state of the volume that is being renamed, so that it is not wrongly
considered as existing after the UUID update completes.

Signed-off-by: Alexandre Sollier <alexandre.sollier@vates.tech>

Author: Kuruyia

drivers/linstorvolumemanager.py

@@ -1060,9 +1060,10 @@ def update_volume_uuid(self, volume_uuid, new_volume_uuid, force=False):
                 .format(volume_uuid)
             )
 
-        # 1. Copy in temp variables metadata and volume_name.
+        # 1. Copy in temp variables metadata, volume_name and not_exists.
         metadata = volume_properties.get(self.PROP_METADATA)
         volume_name = volume_properties.get(self.PROP_VOLUME_NAME)
+        not_exists = volume_properties.get(self.PROP_NOT_EXISTS)
 
         # 2. Switch to new volume namespace.
         volume_properties.namespace = self._build_volume_namespace(
@@ -1093,7 +1094,7 @@ def update_volume_uuid(self, volume_uuid, new_volume_uuid, force=False):
             volume_properties[self.PROP_VOLUME_NAME] = volume_name
 
             # 5. Ok!
-            volume_properties[self.PROP_NOT_EXISTS] = self.STATE_EXISTS
+            volume_properties[self.PROP_NOT_EXISTS] = not_exists
         except Exception as err:
             try:
                 # Clear the new volume properties in case of failure.
@@ -1138,7 +1139,8 @@ def update_volume_uuid(self, volume_uuid, new_volume_uuid, force=False):
             # we are processing a deleted resource.
             assert force
 
-        self._volumes.add(new_volume_uuid)
+        if not_exists == self.STATE_EXISTS:
+            self._volumes.add(new_volume_uuid)
 
         self._logger(
             'UUID update succeeded of {} to {}! (properties={})'