Skip to content

Commit 8f5dd01

Browse files
committed
refactor(cleanup.py): rename "*coalesceVHD" helpers to "*coalesceCowImage"
Signed-off-by: Ronan Abhamon <ronan.abhamon@vates.fr>
1 parent afe4d39 commit 8f5dd01

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

drivers/cleanup.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -820,7 +820,7 @@ def _doCoalesce(self) -> None:
820820
self.parent.validate(True)
821821
self.parent._increaseSizeVirt(self.sizeVirt)
822822
self.sr._updateSlavesOnResize(self.parent)
823-
self._coalesceVHD(0)
823+
self._coalesceCowImage(0)
824824
self.parent.validate(True)
825825
#self._verifyContents(0)
826826
self.parent.updateBlockInfo()
@@ -898,7 +898,7 @@ def coalesce(self) -> int:
898898
return vhdutil.coalesce(self.path) * 512
899899

900900
@staticmethod
901-
def _doCoalesceVHD(vdi):
901+
def _doCoalesceCowImage(vdi):
902902
try:
903903
startTime = time.time()
904904
allocated_size = vdi.getAllocatedSize()
@@ -925,14 +925,14 @@ def _vdi_is_raw(self, vdi_path):
925925
uuid = self.extractUuid(vdi_path)
926926
return self.sr.vdis[uuid].vdi_type == VdiType.RAW
927927

928-
def _coalesceVHD(self, timeOut):
928+
def _coalesceCowImage(self, timeOut):
929929
Util.log(" Running VHD coalesce on %s" % self)
930930
abortTest = lambda: IPCFlag(self.sr.uuid).test(FLAG_TYPE_ABORT)
931931
try:
932932
util.fistpoint.activate_custom_fn(
933933
"cleanup_coalesceVHD_inject_failure",
934934
util.inject_failure)
935-
Util.runAbortable(lambda: VDI._doCoalesceVHD(self), None,
935+
Util.runAbortable(lambda: VDI._doCoalesceCowImage(self), None,
936936
self.sr.uuid, abortTest, VDI.POLL_INTERVAL, timeOut)
937937
except:
938938
#exception at this phase could indicate a failure in vhd coalesce
@@ -2522,7 +2522,7 @@ def _doCoalesceLeaf(self, vdi):
25222522
if vdi.getConfig(vdi.DB_LEAFCLSC) == vdi.LEAFCLSC_FORCE:
25232523
Util.log("Leaf-coalesce forced, will not use timeout")
25242524
timeout = 0
2525-
vdi._coalesceVHD(timeout)
2525+
vdi._coalesceCowImage(timeout)
25262526
util.fistpoint.activate("LVHDRT_coaleaf_after_coalesce", self.uuid)
25272527
vdi.parent.validate(True)
25282528
#vdi._verifyContents(timeout / 2)

0 commit comments

Comments
 (0)