Skip to content

Commit a798abc

Browse files
committed
fix: do not make base copy RO for QCOW2
If we make the base copy RO, the next live coalesce could fail on the call to tapdisk commit since the chain is only made RW at the activation. Signed-off-by: Damien Thenot <damien.thenot@vates.tech>
1 parent d4068f7 commit a798abc

1 file changed

Lines changed: 3 additions & 2 deletions

File tree

drivers/LVMSR.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1864,8 +1864,9 @@ def _snapshot(self, snapType, cloneOp=False, cbtlog=None, cbt_consistency=None,
18641864
util.fistpoint.activate("LVHDRT_clone_vdi_after_parent_hidden", self.sr.uuid)
18651865

18661866
# set the base copy to ReadOnly
1867-
self.sr.lvmCache.setReadonly(self.lvname, True)
1868-
util.fistpoint.activate("LVHDRT_clone_vdi_after_parent_ro", self.sr.uuid)
1867+
if not self.cowutil.isCoalesceableOnRemote():
1868+
self.sr.lvmCache.setReadonly(self.lvname, True)
1869+
util.fistpoint.activate("LVHDRT_clone_vdi_after_parent_ro", self.sr.uuid)
18691870

18701871
if hostRefs:
18711872
self.sr._updateSlavesOnClone(hostRefs, origOldLV,

0 commit comments

Comments
 (0)