feature(lvmsr): enable vdi_revert on all lvm based SRs

Signed-off-by: Antoine Bartuccio <antoine.bartuccio@vates.tech>

Author: klmp200

drivers/LVMSR.py

@@ -232,6 +232,13 @@ class LVMSR(SR.SR):
             TEST_MODE_VHD_FAIL_RESIZE_END:
                 "VHD_UTIL_TEST_FAIL_RESIZE_END"
     }
+
+    # Journals that should prevent VMs from booting while pending
+    _CRITICAL_JOURNALS = [
+        RevertLogEntry.JRN_KEY,
+        InsertCloneLogEntry.JRN_KEY,
+    ]
+
     testMode = ""
 
     legacyMode = True
@@ -328,13 +335,25 @@ def load(self, sr_uuid) -> None:
             self.legacyMode = False
 
         if lvutil._checkVG(self.vgname):
+            # Disable SR on slaves when mounting VDIs if
+            # a critical journal is pending
+            if (
+                not self.isMaster
+                and self.cmd not in ["vdi_detach", "vdi_activate", "vdi_deactivate", "nop"]
+                and self._has_critical_journals()
+            ):
+                raise xs_errors.XenError(
+                    "SRUnavailable", opterr="Critical journals are pending"
+                )
+
             if self.isMaster and not self.cmd in [
                 "vdi_attach",
                 "vdi_detach",
                 "vdi_activate",
                 "vdi_deactivate",
             ]:
                 self._undoAllJournals()
+
             if not self.cmd in ["sr_attach", "sr_probe"]:
                 self._checkMetadataVolume()
 
@@ -1033,6 +1052,12 @@ def _loadvdis(self):
                 util.SMlog("Scan found hidden leaf (%s), ignoring" % uuid)
                 del self.vdis[uuid]
 
+    def _has_critical_journals(self) -> bool:
+        for key in self._CRITICAL_JOURNALS:
+            if any(self.journaler.getAll(key)):
+                return True
+        return False
+
     def _ensureSpaceAvailable(self, amount_needed):
         space_available = lvutil._getVGstats(self.vgname)['freespace']
         if (space_available < amount_needed):

drivers/LVMoFCoESR.py

@@ -34,7 +34,7 @@
                 "VDI_GENERATE_CONFIG", "VDI_SNAPSHOT", "VDI_CLONE",
                 "VDI_RESIZE", "ATOMIC_PAUSE", "VDI_RESET_ON_BOOT/2",
                 "VDI_UPDATE", "VDI_MIRROR", "VDI_CONFIG_CBT", "VDI_ACTIVATE",
-                "VDI_DEACTIVATE"]
+                "VDI_DEACTIVATE", "VDI_REVERT"]
 
 CONFIGURATION = [['SCSIid', 'The scsi_id of the destination LUN'],
                 ['allocation', 'Valid values are thick or thin(optional,\

drivers/LVMoHBASR.py

@@ -41,7 +41,7 @@
                 "VDI_CREATE", "VDI_DELETE", "VDI_ATTACH", "VDI_DETACH",
                 "VDI_GENERATE_CONFIG", "VDI_SNAPSHOT", "VDI_CLONE", "VDI_MIRROR",
                 "VDI_RESIZE", "ATOMIC_PAUSE", "VDI_RESET_ON_BOOT/2",
-                "VDI_UPDATE", "VDI_CONFIG_CBT", "VDI_ACTIVATE", "VDI_DEACTIVATE"]
+                "VDI_UPDATE", "VDI_CONFIG_CBT", "VDI_ACTIVATE", "VDI_DEACTIVATE", "VDI_REVERT"]
 
 CONFIGURATION = [['SCSIid', 'The scsi_id of the destination LUN'], \
                   ['allocation', 'Valid values are thick or thin (optional, defaults to thick)']]

drivers/LVMoISCSISR.py

@@ -45,7 +45,7 @@
                 "VDI_GENERATE_CONFIG", "VDI_CLONE", "VDI_SNAPSHOT",
                 "VDI_RESIZE", "ATOMIC_PAUSE", "VDI_RESET_ON_BOOT/2",
                 "VDI_UPDATE", "VDI_MIRROR", "VDI_CONFIG_CBT",
-                "VDI_ACTIVATE", "VDI_DEACTIVATE"]
+                "VDI_ACTIVATE", "VDI_DEACTIVATE", "VDI_REVERT"]
 
 CONFIGURATION = [['SCSIid', 'The scsi_id of the destination LUN'], \
                   ['target', 'IP address or hostname of the iSCSI target'], \