Skip to content

Commit 2eae733

Browse files
committed
storage: skip NFSv4 large VDI tests due to known performance issue
Skip test_coalesce and test_vdi_export_import when running on NFSv4 with VDI size > 20 GiB, as NFSv4 performance issues make these tests too slow. Signed-off-by: Gaëtan Lehmann <gaetan.lehmann@vates.tech>
1 parent 53716cf commit 2eae733

1 file changed

Lines changed: 8 additions & 1 deletion

File tree

tests/storage/nfs/test_nfs_sr.py

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,9 @@
22

33
import pytest
44

5+
from lib import config
56
from lib.commands import SSHCommandFailed
6-
from lib.common import Defer, vm_image, wait_for
7+
from lib.common import Defer, GiB, vm_image, wait_for
78
from lib.host import Host
89
from lib.sr import SR
910
from lib.vdi import VDI
@@ -119,6 +120,8 @@ def test_snapshot(self, dispatch_nfs: VM) -> None:
119120
@pytest.mark.parametrize('dispatch_nfs', ['vdi_on_nfs_sr', 'vdi_on_nfs4_sr'], indirect=True)
120121
@pytest.mark.parametrize('vdi_op', ['snapshot', 'clone'])
121122
def test_coalesce(self, storage_test_vm: VM, dispatch_nfs: VDI, vdi_op: CoalesceOperation, defer: Defer) -> None:
123+
if "NFS4" in dispatch_nfs.sr.get_name_label() and config.volume_size > 20 * GiB:
124+
pytest.skip("Skipping NFSv4 large VDI test (known performance issue)")
122125
coalesce_integrity(storage_test_vm, dispatch_nfs, vdi_op, defer)
123126

124127
@pytest.mark.small_vm
@@ -139,12 +142,16 @@ def test_invalid_vdi_size(self, nfs_sr: SR, image_format: ImageFormat):
139142
@pytest.mark.parametrize("compression", ["none", "gzip", "zstd"])
140143
def test_xva_export_import(self, dispatch_nfs: VM, compression: XVACompression, temp_large_dir: str, defer: Defer) \
141144
-> None:
145+
if "NFS4" in dispatch_nfs.vdis[0].sr.get_name_label() and config.volume_size > 20 * GiB:
146+
pytest.skip("Skipping NFSv4 large VDI test (known performance issue)")
142147
xva_export_import(dispatch_nfs, compression, temp_large_dir, defer)
143148

144149
@pytest.mark.small_vm
145150
@pytest.mark.parametrize('dispatch_nfs', ['nfs_sr', 'nfs4_sr'], indirect=True)
146151
def test_vdi_export_import(self, storage_test_vm: VM, dispatch_nfs: SR, image_format: ImageFormat,
147152
temp_large_dir: str, defer: Defer) -> None:
153+
if "NFS4" in dispatch_nfs.get_name_label() and config.volume_size > 20 * GiB:
154+
pytest.skip("Skipping NFSv4 large VDI test (known performance issue)")
148155
vdi_export_import(storage_test_vm, dispatch_nfs, image_format, temp_large_dir, defer)
149156

150157
# *** tests with reboots (longer tests).

0 commit comments

Comments
 (0)