tools/update: rename master/secondary to be more coherent

Signed-off-by: Olivier Hoareau <olivier.hoareau@vates.tech>

Author: olivierh-pro

README.md

@@ -641,17 +641,17 @@ uv run scripts/tools.py -h
 This command performs an update operation on remote targets.
 
 ```bash
-uv run scripts/tools.py update -H primary1 primary2
+uv run scripts/tools.py update -H master1 master2
 ```
 
 For each pool target :
 
-1. Update master (primary) host of the pool:
+1. Update master host of the pool:
   * Clean cached metadata
   * Update with repository manager (yum): Optionally enables repositories
   * Reboot
-2. Get attached secondary hosts of the pool
-  * Repeat step `1.` for each secondary
+2. Get other hosts of the pool
+  * Repeat step `1.` for each host
 
 **Inventory file**
 
@@ -692,4 +692,4 @@ hosting_pool = "B"
 >
 > `{'ip_or_hostname-1': {'repositories': ['xcp-ng-base'], 'hosting_pool': 'A'}, 'ip_or_hostname-2': {'repositories': ['xcp-ng-updates'], 'hosting_pool': 'B'}}`
 >
-> * Using *enablerepo flag* `-e` with inventory is still possible, it won't be used though.
+> * When `--inventory` flag is present, repos passed to `-e` flag won't be considered.

lib/pool.py

@@ -17,7 +17,7 @@
 class Pool:
     """Pool
 
-    :raises NotAMasterHostError: if initial host is not a master (primary)
+    :raises NotAMasterHostError: if initial host is not a master
     """
     xe_prefix = "pool"
 
@@ -300,4 +300,4 @@ def network_named(self, network_name: str) -> str:
         return self.master.xe('network-list', {'name-label': network_name}, minimal=True)
 
 class NotAMasterHostError(Exception):
-    """Host must be a master (primary)."""
+    """Host must be a master."""

lib/tools/tasks/update.py

@@ -18,7 +18,7 @@ def update_pools(inventory: Inventory) -> None:
 
         Every non-master hosts in inventory will be ignored
 
-    *Update master hosts declared in inventory first, then, update secondary hosts attached to each master.*
+    *Update each pool's master host declared in inventory first, then, update other hosts for each pool.*
 
     :param dict inventory:
         Each host (key) holds its own config data (values, eg: `enablerepos`).
@@ -34,15 +34,16 @@ def update_pools(inventory: Inventory) -> None:
         except NotAMasterHostError:
             logger.warning(f"[{host}] Skipping: not a master host")
 
+    # update master hosts
     with ThreadPoolExecutor() as executor:
         for p in pools:
             executor.submit(p.master.update, inventory_hosts[p.master.hostname_or_ip]["repositories"])
 
-    # secondary hosts
+    # update other hosts
     with ThreadPoolExecutor() as executor:
         for p in pools:
-            # omit first item because it is a primary (master)
-            for secondary in p.hosts[1:]:
-                # repos are the same as the primary (master)
+            # omit first item because it is the pool's master
+            for other_host in p.hosts[1:]:
+                # repos are the same as for the master host
                 repos = inventory_hosts[p.master.hostname_or_ip]["repositories"]
-                executor.submit(secondary.update, repos)
+                executor.submit(other_host.update, repos)