lib/vdi: Add VDI resize support and integrate into VM & linstor operations

- Added `resize` method to `VDI` class to allow resizing of VDIs via `xe vdi-resize`.
- Introduced `vdi_resize` method in VM class to support 2x VDI resizing.
- Implemented `test_resize_vdi` in Linstor and basic VM tests, verifying VDI resize functionality and ensuring VM boot post-resize.
- Refactored VM operations to include `wait_for_vm_running`.

Signed-off-by: Rushikesh Jadhav <[email protected]>

Author: rushikeshjadhav

Diff for: lib/vdi.py

@@ -31,6 +31,10 @@ def clone(self):
     def readonly(self):
         return self.param_get("read-only") == "true"
 
+    def resize(self, vdi_size):
+        logging.info("Resize VDI %s", self.uuid)
+        self.sr.pool.master.xe('vdi-resize', {'uuid': self.uuid, 'disk-size': vdi_size})
+
     def __str__(self):
         return f"VDI {self.uuid} on SR {self.sr.uuid}"
 

Diff for: lib/vm.py

@@ -10,6 +10,7 @@
 from lib.common import PackageManagerEnum, parse_xe_dict, safe_split, strtobool, wait_for, wait_for_not
 from lib.snapshot import Snapshot
 from lib.vif import VIF
+from lib.vdi import VDI
 
 class VM(BaseVM):
     def __init__(self, uuid, host):
@@ -130,6 +131,9 @@ def wait_for_vm_running_and_ssh_up(self):
         self.wait_for_os_booted()
         wait_for(self.is_ssh_up, "Wait for SSH up")
 
+    def wait_for_vm_running(self):
+        wait_for(self.is_running)
+
     def ssh_touch_file(self, filepath):
         logging.info("Create file on VM (%s)" % filepath)
         self.ssh(['touch', filepath])
@@ -361,6 +365,24 @@ def test_snapshot_on_running_vm(self):
         finally:
             snapshot.destroy(verify=True)
 
+    def vdi_resize(self, vdi_uuid, new_size=None):
+        # Reference
+        MAX_VHD_SIZE = 2088960 * 1024 * 1024 # 2088960 MB
+        MIN_VHD_SIZE = 1 * 1024 * 1024 # 1MB
+
+        # Following assert may be removed in future if we support online vdi resize
+        assert not self.is_running(), f"Expected halted, got running"
+
+        vdi_obj = VDI(vdi_uuid, sr=self.get_sr())
+        if new_size is None:
+            # Resize by double, ideally it should be within min and max limits reference
+            vdi_size = int(vdi_obj.param_get("virtual-size"))
+            new_size = str(vdi_size * 2)
+
+        vdi_obj.resize(new_size)
+        resized_vdi_size = vdi_obj.param_get("virtual-size")
+        assert int(resized_vdi_size) == int(new_size), f"Expected {new_size}, got {resized_vdi_size}"
+
     def get_messages(self, name):
         args = {
             'obj-uuid': self.uuid,

Diff for: tests/misc/test_basic_without_ssh.py

@@ -75,6 +75,22 @@ def test_checkpoint(self, imported_vm):
         finally:
             snapshot.destroy(verify=True)
 
+    def test_resize_vdi(self, imported_vm):
+        from lib.vdi import VDI
+
+        vm = imported_vm
+        if vm.is_running():
+            vm.shutdown(verify=True, force_if_fails=True)
+
+        logging.info("* VDI Resize started *")
+        for vdi_uuid in vm.vdi_uuids():
+            vm.vdi_resize(vdi_uuid)
+        logging.info("* VDI Resize completed *")
+
+        vm.start()
+        vm.wait_for_vm_running() # early decision to check if VDI was ok and VM is able to start
+        vm.shutdown(verify=True, force_if_fails=True)
+
     # Live migration tests
     # We want to test storage migration (memory+disks) and live migration without storage migration (memory only).
     # The order will depend on the initial location of the VM: a local SR or a shared SR.

Diff for: tests/storage/linstor/test_linstor_sr.py

@@ -78,6 +78,17 @@ def test_snapshot(self, vm_on_linstor_sr):
         finally:
             vm.shutdown(verify=True)
 
+    @pytest.mark.small_vm
+    @pytest.mark.big_vm
+    def test_resize_vdi(self, vm_on_linstor_sr):
+        vm = vm_on_linstor_sr
+        if vm.is_running():
+            vm.shutdown(verify=True, force_if_fails=True)
+        logging.info("* VDI Resize started *")
+        for vdi_uuid in vm.vdi_uuids():
+            vm.vdi_resize(vdi_uuid)
+        logging.info("* VDI Resize completed *")
+
     # *** tests with reboots (longer tests).
 
     @pytest.mark.reboot