Skip to content

Commit 6dcac9d

Browse files
committed
storage: skip NFSv4 large VDI tests due to known performance issue
Skip test_coalesce and test_vdi_export_import when running on NFSv4 with VDI size > 20 GiB, as NFSv4 performance issues make these tests too slow. Signed-off-by: Gaëtan Lehmann <gaetan.lehmann@vates.tech>
1 parent 58d615f commit 6dcac9d

1 file changed

Lines changed: 10 additions & 1 deletion

File tree

tests/storage/nfs/test_nfs_sr.py

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,9 @@
22

33
import pytest
44

5+
from lib import config
56
from lib.commands import SSHCommandFailed
6-
from lib.common import Defer, vm_image, wait_for
7+
from lib.common import Defer, GiB, vm_image, wait_for
78
from lib.sr import SR
89
from lib.vdi import VDI
910
from lib.vm import VM
@@ -120,6 +121,11 @@ def test_snapshot(self, dispatch_nfs):
120121
def test_coalesce(
121122
self, storage_test_vm: VM, dispatch_nfs: VDI, vdi_op: CoalesceOperation, defer: Defer
122123
):
124+
sr_name = dispatch_nfs.sr.pool.master.xe(
125+
'sr-param-get', {'uuid': dispatch_nfs.sr.uuid, 'param-name': 'name-label'}
126+
)
127+
if "NFS4" in sr_name and config.volume_size > 20 * GiB:
128+
pytest.skip("Skipping NFSv4 large VDI test (known performance issue)")
123129
coalesce_integrity(storage_test_vm, dispatch_nfs, vdi_op, defer)
124130

125131
@pytest.mark.small_vm
@@ -146,6 +152,9 @@ def test_xva_export_import(self, dispatch_nfs: VM, compression: XVACompression,
146152
def test_vdi_export_import(
147153
self, storage_test_vm: VM, dispatch_nfs: SR, image_format: ImageFormat, temp_large_dir: str, defer: Defer
148154
):
155+
sr_name = dispatch_nfs.pool.master.xe('sr-param-get', {'uuid': dispatch_nfs.uuid, 'param-name': 'name-label'})
156+
if "NFS4" in sr_name and config.volume_size > 20 * GiB:
157+
pytest.skip("Skipping NFSv4 large VDI test (known performance issue)")
149158
vdi_export_import(storage_test_vm, dispatch_nfs, image_format, temp_large_dir, defer)
150159

151160
# *** tests with reboots (longer tests).

0 commit comments

Comments
 (0)